-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-appsync): RdsDataSource misses option to set dataBaseName #12572
(aws-appsync): RdsDataSource misses option to set dataBaseName #12572
Comments
this is still not resolved in |
@Simon-TechForm my workaround here is as follows. But I really hope AWS is not neglecting the CDK and will take your PRs soon. /**
* Database Data Source
* TODO: Missing databaseName and databaseSchema https://github.com/aws/aws-cdk/issues/12572
*/
const databaseDataSource = api.addRdsDataSource(
"DatabaseDataSource",
(databaseCluster as unknown) as rds.IDatabaseCluster,
databaseCluster.secret as secretsManager.ISecret,
{
description: "My Product Serverless Aurora RDS Database Data Source",
name: "MyProductDatabaseDataSource",
}
);
/**
* TODO: Missing databaseName and databaseSchema https://github.com/aws/aws-cdk/issues/12572
*/
const cfnDataSource = databaseDataSource.node.defaultChild as appsync.CfnDataSource;
cfnDataSource.addPropertyOverride("RelationalDatabaseConfig.RdsHttpEndpointConfig.DatabaseName", "my_product");
cfnDataSource.addPropertyOverride("RelationalDatabaseConfig.RdsHttpEndpointConfig.Schema", "public"); |
Fixes: #12572 BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Fixes: #12572 BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Creating seperate issues for #12503 to improve structure.
It seems like there's no way to add the databasename to a RdsDataSource, which results in a "No database selected" error when running a resolver.
Reproduction Steps
What did you expect to happen?
addRdsDataSource to include a prop for databaseName.
What actually happened?
There's no prop for databaseName.
Environment
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: