Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-appsync): add databaseName to rdsDataSource #12575

Merged
merged 4 commits into from
Feb 19, 2021
Merged

feat(aws-appsync): add databaseName to rdsDataSource #12575

merged 4 commits into from
Feb 19, 2021

Conversation

monholm
Copy link
Contributor

@monholm monholm commented Jan 18, 2021

Fixes: #12572

BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Fixes: #12572

BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument
@gitpod-io
Copy link

gitpod-io bot commented Jan 18, 2021

@github-actions github-actions bot added the @aws-cdk/aws-appsync Related to AWS AppSync label Jan 18, 2021
@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: a2175d0
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Feb 19, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit f92b65e into aws:master Feb 19, 2021
eladb pushed a commit that referenced this pull request Feb 22, 2021
Fixes: #12572

BREAKING CHANGE: graphqlapi.addRdsDataSource now takes databaseName as its fourth argument


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-appsync Related to AWS AppSync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(aws-appsync): RdsDataSource misses option to set dataBaseName
3 participants