-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(cdk-pipelines): Build fails after updating CDK to 1.87.0 - not authorized to perform: ssm:GetParameters on resource: arn:aws:ssm:eu-central-1:88888888:parameter/ENV_VARIABLE status code: 400, request id #12742
Comments
This seems to be an ECS issue, agreed? |
You did not say WHEN the error occurred. During a synth, or during the CloudFormation deployment, or during the run of the ECS container that is a result of the deployment, or... ? |
@rix0rrr This happened during the build of the Docker asset in question |
Also the following code specifying synthAction: pipelines.SimpleSynthAction.standardNpmSynth({
sourceArtifact,
cloudAssemblyArtifact,
subdirectory: 'cdk',
environmentVariables: {
NPM_TOKEN: {
type: codebuild.BuildEnvironmentVariableType.PARAMETER_STORE,
value: 'npm-token'
},
},
}), Is it possibly due to this? 736b260#diff-d3cb29eee3f26a140a30213c958a5739b9abbae4ba62f3d6318417ef6ac8f930L323 |
…iables We correctly added permissions for SSM and SecretsManager-type environment variables set on the CodeBuild Project itself, but we forgot that environment variables could also be set on the CodeBuild CodePipeline action. Fixes aws#12742
Thanks for reporting @markusl. You are correct about the reason. PR with a fix posted. |
…iables (#12761) We correctly added permissions for SSM and SecretsManager-type environment variables set on the CodeBuild Project itself, but we forgot that environment variables could also be set on the CodeBuild CodePipeline action. Fixes #12742 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Unfortunately no - Apologies for the inconvenience this caused @markusl! |
Perhaps rolling back to |
@skinny85 our CDK Pipelines rollout for container apps has been blocked and waiting for #11815 to be fixed. Now it's fixed but our other pipelines, and I guess most of them, got broken because of the permission error (we try to always update to the latest version). Since this is a regression in a stable module (codepipeline) I would like to understand why it is not considered worth fixing as a hotfix to retain previous functionality? Br, |
@markusl this is actually not a regression in the CodePipeline module, as this never properly worked 😜. It is a regression in the Pipelines module, though. Can you see if the workaround described in this comment can help you on |
…iables (aws#12761) We correctly added permissions for SSM and SecretsManager-type environment variables set on the CodeBuild Project itself, but we forgot that environment variables could also be set on the CodeBuild CodePipeline action. Fixes aws#12742 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
It seems handling of the
secrets
has been changed in AWS CDK 1.87.0 so that the requiredssm:GetParameters
policy is not created any more.Reproduction Steps
What did you expect to happen?
I would not expect to see any diff in IAM roles after upgrading.
What actually happened?
Environment
Other
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: