Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(neptune): Higher level constructs for Neptune #12762

Closed
1 of 2 tasks
cornerwings opened this issue Jan 29, 2021 · 2 comments · Fixed by #12763
Closed
1 of 2 tasks

(neptune): Higher level constructs for Neptune #12762

cornerwings opened this issue Jan 29, 2021 · 2 comments · Fixed by #12763
Assignees
@njlynch
Labels
@aws-cdk/aws-neptune Related Amazon Neptune feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@cornerwings
Copy link
Contributor

Add level 2 constructs for the Amazon Neptune.

Use Case

CDK users who want to build applications that use Neptune currently have to use level 1 constructs or implement their own higher-level constructs.

Proposed Solution

The level 2 constructs from the @aws-cdk/aws-rds package in CDK offers a good starting point since their CloudFormation resource specifications follow a similar architecture. From there, the code must be reviewed and modified to reflect Neptune's CloudFormation resources.

Other

N/A

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@cornerwings cornerwings added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 29, 2021
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Jan 29, 2021
cornerwings added a commit to cornerwings/aws-cdk that referenced this issue Jan 29, 2021
@cornerwings
feat(neptune): high level constructs for db clusters and instances
d20baad 
* This change adds higher level constructs for Neptune clusters
* Adds higher-level constructs for
  ** AWS::Neptune::DBCluster
  ** AWS::Neptune::DBInstance
  ** AWS::Neptune::DBClusterParameterGroup
  ** AWS::Neptune::DBParameterGroup
  ** AWS::Neptune::DBSubnetGroup

fixes aws#12762
cornerwings added a commit to cornerwings/aws-cdk that referenced this issue Jan 29, 2021
@cornerwings
feat(neptune): high level constructs for db clusters and instances
06c8df5 
- This change adds higher level constructs for Neptune clusters
- Adds higher-level constructs for
  - AWS::Neptune::DBCluster
  - AWS::Neptune::DBInstance
  - AWS::Neptune::DBClusterParameterGroup
  - AWS::Neptune::DBParameterGroup
  - AWS::Neptune::DBSubnetGroup

fixes aws#12762
@NetaNir
Copy link
Contributor

NetaNir commented Jan 29, 2021

duplicate of #6857

@NetaNir NetaNir closed this as completed Jan 29, 2021
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

cornerwings added a commit to cornerwings/aws-cdk that referenced this issue Jan 29, 2021
@cornerwings
feat(neptune): high level constructs for db clusters and instances
ba6b525 
- This change adds higher level constructs for Neptune clusters
- Adds higher-level constructs for
  - AWS::Neptune::DBCluster
  - AWS::Neptune::DBInstance
  - AWS::Neptune::DBClusterParameterGroup
  - AWS::Neptune::DBParameterGroup
  - AWS::Neptune::DBSubnetGroup

fixes aws#12762
@cornerwings cornerwings mentioned this issue Jan 29, 2021
Merged
mergify bot pushed a commit that referenced this issue Mar 1, 2021
@cornerwings
feat(neptune): high level constructs for db clusters and instances (#…
c366837 
…12763)

- This change adds higher level constructs for Neptune clusters
- Adds higher-level constructs for
  - AWS::Neptune::DBCluster
  - AWS::Neptune::DBInstance
  - AWS::Neptune::DBClusterParameterGroup
  - AWS::Neptune::DBParameterGroup
  - AWS::Neptune::DBSubnetGroup

fixes #12762


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-neptune Related Amazon Neptune feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune): high level constructs for db clusters and instances cornerwings/aws-cdk
3 participants
@cornerwings @njlynch @NetaNir