Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(redshift): Missing current generation NodeTypes #12783

Closed
1 of 2 tasks
mbeacom opened this issue Jan 30, 2021 · 1 comment · Fixed by #12784
Closed
1 of 2 tasks

(redshift): Missing current generation NodeTypes #12783

mbeacom opened this issue Jan 30, 2021 · 1 comment · Fixed by #12784
Assignees
@njlynch
Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1

Comments

@mbeacom
Copy link
Contributor

mbeacom commented Jan 30, 2021

I would like to expand the available NodeTypes to include all current generation node types.

Use Case

Deploy any of the available, current generation Redshift node types.

e.g. ra3.xplus

from aws_cdk import aws_redshift as rs
...
cluster = rs.Cluster(
    self, "RedshiftCluster",
    master_user=rs.Login(master_username="someadmin"),
    node_type=rs.NodeType.RA3_XLPLUS,
)

Proposed Solution

Add missing, current generation node types (ra3.xlplus & ra3.4xlarge) to cluster.ts@NodeType#L18-47

Other

  /**
   * ra3.xlplus
   */
  RA3_XLPLUS = 'ra3.xlplus',
  /**
   * ra3.4xlarge
   */
  RA3_4XLARGE = 'ra3.4xlarge',
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@mbeacom mbeacom added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jan 30, 2021
mbeacom added a commit to mbeacom/aws-cdk that referenced this issue Jan 30, 2021
@mbeacom
feat(redshift): add missing current generation RA3 NodeTypes
13a69c8 
Adds the missing Redshift RA3 NodeTypes (ra3.xlplus, ra3.4xlarge).

closes aws#12783
mbeacom added a commit to mbeacom/aws-cdk that referenced this issue Jan 30, 2021
@mbeacom
feat(redshift): add missing current generation RA3 NodeTypes
8632313 
Adds the missing Redshift RA3 NodeTypes (ra3.xlplus, ra3.4xlarge).

closes aws#12783
@mbeacom mbeacom mentioned this issue Jan 30, 2021
Merged
@NGL321 NGL321 changed the title (@aws-cdk/redshift): Missing current generation NodeTypes (redshift): Missing current generation NodeTypes Feb 1, 2021
@github-actions github-actions bot added the @aws-cdk/aws-redshift Related to Amazon Redshift label Feb 1, 2021
@njlynch njlynch added effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 9, 2021
@mergify mergify bot closed this as completed in #12784 Feb 9, 2021
mergify bot pushed a commit that referenced this issue Feb 9, 2021
@mbeacom
feat(redshift): add missing current generation RA3 NodeTypes (#12784)
f91a3f1 
Adds the missing Redshift RA3 NodeTypes (ra3.xlplus, ra3.4xlarge).

closes #12783


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Feb 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TLadd pushed a commit to TLadd/aws-cdk that referenced this issue Feb 9, 2021
@mbeacom @TLadd
feat(redshift): add missing current generation RA3 NodeTypes (aws#12784)
f47df6c 
Adds the missing Redshift RA3 NodeTypes (ra3.xlplus, ra3.4xlarge).

closes aws#12783


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
NovakGu pushed a commit to NovakGu/aws-cdk that referenced this issue Feb 18, 2021
@mbeacom @NovakGu
feat(redshift): add missing current generation RA3 NodeTypes (aws#12784)
a843101 
Adds the missing Redshift RA3 NodeTypes (ra3.xlplus, ra3.4xlarge).

closes aws#12783


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-redshift Related to Amazon Redshift effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(redshift): add missing current generation RA3 NodeTypes mbeacom/aws-cdk
2 participants
@njlynch @mbeacom