aws-lambda-nodejs: spaces in path-name results in error

[simon-dk]

Spaces in paths can break cdk synth when using @aws-cdk/aws-lambda-nodejs construct together with esbuild.
The resulting error is: "error: Must use "outdir" when there are multiple input files".

Sample repo

https://github.com/Simon-SDK/cdk_bug_report

Steps

Install repo and run "cdk synth".

Description

The error happens because of these two lines:

aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/lib/bundling.ts

Line 143 in 296a10d

'--bundle', pathJoin(inputDir, this.relativeEntryPath),

aws-cdk/packages/@aws-cdk/aws-lambda-nodejs/lib/bundling.ts

Line 146 in 296a10d

`--outfile=${pathJoin(outputDir, 'index.js')}`,

The output of the esbuildCommand returns un-escaped paths, making esbuild believe there are multiple files, example:

npx esbuild --bundle /.../cdk/lib/lambda function/index.ts --target=node12 --platform=node --outfile=/.../cdk/cdk.out/bundling-temp-d5ad4854b4c5ea5068744c5b1b87fe2b04eec6a7aae0e3bdd2928a97638d2e5f/index.js --external:aws-sdk

If the lambda folder in the sample repo is changed to "lambda_function", "cdk synth" runs fine.

What did you expect to happen?

Cdk synth should build a index.js using esbuild without crashing.

What actually happened?

esbuild crashes because it (wrongly) expects multiple input-files.

Environment

• CDK CLI Version: 1.87.0
• **Framework Version:**1.90.1
• Node.js Version: v12.16.1
• OS : macOS 10.13.6
• Language (Version): TypeScript (4.1.5)

Other

---

This is 🐛 Bug Report

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.