Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package managers: deprecate @aws-cdk/aws-sam #1322

Closed
iamatypeofwalrus opened this issue Dec 11, 2018 · 3 comments
Closed

Package managers: deprecate @aws-cdk/aws-sam #1322

iamatypeofwalrus opened this issue Dec 11, 2018 · 3 comments
Labels
bug This issue is a bug.

Comments

@iamatypeofwalrus
Copy link

iamatypeofwalrus commented Dec 11, 2018

I ran into this with the latest version of aws-sam (0.13.0). According to #1137 this was meant to be fixed in #1091, however, that doesn't seem to be the case. After upgrading to the latest version of the cdk the @aws-cdk/aws-serverless works as expected.

Full error output:

[ts]
Argument of type 'this' is not assignable to parameter of type 'Construct'.
  Type 'QuizStack' is not assignable to type 'Construct'.
    Types of property 'parent' are incompatible.
      Type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/cdk/lib/core/construct").Construct | undefined' is not assignable to type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/aws-sam/node_modules/@aws-cdk/cdk/lib/core/construct").Construct | undefined'.
        Type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/cdk/lib/core/construct").Construct' is not assignable to type 'import("/Users/joe/code/quiz/node_modules/@aws-cdk/aws-sam/node_modules/@aws-cdk/cdk/lib/core/construct").Construct'.
          Types have separate declarations of a private property '_children'. [2345]

CDK Version: 0.19.0 (build 2625a05)
Package dot JSON:

{
  "name": "quiz",
  "version": "0.1.0",
  "bin": {
    "quiz2": "bin/quiz.js"
  },
  "scripts": {
    "build": "tsc",
    "watch": "tsc -w",
    "cdk": "cdk"
  },
  "devDependencies": {
    "@types/node": "^8.9.4",
    "typescript": "^3.1.2",
    "aws-cdk": "^0.19.0"
  },
  "dependencies": {
    "@aws-cdk/aws-sam": "^0.13.0",
    "@aws-cdk/cdk": "^0.19.0"
  }
}
@iamatypeofwalrus iamatypeofwalrus changed the title Typescript @aws-cdk/sam and @aws-cdk/serverless contain their own version of the CDK Typescript @aws-cdk/aws-sam and @aws-cdk/aws-serverless contain their own version of the CDK Dec 11, 2018
@iamatypeofwalrus iamatypeofwalrus changed the title Typescript @aws-cdk/aws-sam and @aws-cdk/aws-serverless contain their own version of the CDK Typescript @aws-cdk/aws-sam contains its own version of the CDK Dec 11, 2018
@rix0rrr
Copy link
Contributor

rix0rrr commented Dec 11, 2018

Yes, @aws-cdk/aws-sam is actually deprecated. You shouldn't be using it anymore. Let's figure out a way to make that clearer on NPM.

@rix0rrr rix0rrr changed the title Typescript @aws-cdk/aws-sam contains its own version of the CDK Package managers: deprecate @aws-cdk/aws-sam Dec 11, 2018
@rix0rrr rix0rrr added the bug This issue is a bug. label Dec 11, 2018
@iamatypeofwalrus
Copy link
Author

👍 Can the docs also make it clear that its deprecated?

@eladb
Copy link
Contributor

eladb commented Apr 2, 2019

We have actually reverted the name to SAM and deprecated Serverless #2092 #2074

@eladb eladb closed this as completed Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue is a bug.
Projects
None yet
Development

No branches or pull requests

3 participants