Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(serverless): rename aws-serverless to aws-sam #2074

Merged
merged 5 commits into from
Mar 26, 2019

Conversation

sam-goodwin
Copy link
Contributor

@sam-goodwin sam-goodwin commented Mar 22, 2019

BREAKING CHANGE: renamed aws-serverless to aws-sam


Pull Request Checklist

  • Testing
    • Unit test added (prefer not to modify an existing test, otherwise, it's probably a breaking change)
    • CLI change?: coordinate update of integration tests with team
    • cdk-init template change?: coordinated update of integration tests with team
  • Docs
    • jsdocs: All public APIs documented
    • README: README and/or documentation topic updated
  • Title and Description
    • Change type: title prefixed with fix, feat will appear in changelog
    • Title: use lower-case and doesn't end with a period
    • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
    • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
  • Sensitive Modules (requires 2 PR approvers)
    • IAM Policy Document (in @aws-cdk/aws-iam)
    • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
    • Grant APIs (only if not based on official documentation with a reference)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

@sam-goodwin sam-goodwin requested a review from a team as a code owner March 22, 2019 00:48
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 22, 2019

Again??

@@ -1,5 +0,0 @@
## AWS Serverless Construct Library
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My diff only shows 1 file removed from this package. Is that right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The rest were identified as renamed. I changed the content of the README so that's why it shows up as removed, or so I assume.

packages/@aws-cdk/aws-sam/README.md Outdated Show resolved Hide resolved
tools/cfn2ts/lib/genspec.ts Show resolved Hide resolved
@sam-goodwin sam-goodwin merged commit 4a82f13 into master Mar 26, 2019
@sam-goodwin sam-goodwin deleted the samgood/serverless-rename-to-sam branch March 26, 2019 04:48
@eladb
Copy link
Contributor

eladb commented Mar 26, 2019

Damn we forgot #2092

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants