Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ses): use lambda.Runtime.NODEJS_12_X in DropSpamReceiptRule #13223

Closed
2 tasks done
trivikr opened this issue Feb 23, 2021 · 2 comments · Fixed by #13266
Closed
2 tasks done

(aws-ses): use lambda.Runtime.NODEJS_12_X in DropSpamReceiptRule #13223

trivikr opened this issue Feb 23, 2021 · 2 comments · Fixed by #13266
Assignees
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@trivikr
Copy link
Member

trivikr commented Feb 23, 2021

DropSpamReceiptRule currently uses lambda.Runtime.NODEJS_10_X

const fn = new lambda.SingletonFunction(this, 'Function', {
runtime: lambda.Runtime.NODEJS_10_X,
handler: 'index.handler',
code: lambda.Code.fromInline(`exports.handler = ${dropSpamCode}`),
uuid: '224e77f9-a32e-4b4d-ac32-983477abba16',
});

Use lambda.Runtime.NODEJS_12_X instead.

Use Case

Reasons for recommending NODEJS_12_X:

  • Node.js 12.x went LTS in October 2019, and has been actively supported since October 2020.
  • Node.js 10.x is going end-of-life on April 30th, 2021

https://endoflife.date/nodejs

Proposed Solution

Use lambda.Runtime.NODEJS_12_X in DropSpamReceiptRule.

Other

Suggested in #12808 (comment)

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@trivikr trivikr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2021
@github-actions github-actions bot added @aws-cdk/aws-lambda Related to AWS Lambda @aws-cdk/aws-ses Related to Amazon Simple Email Service labels Feb 23, 2021
@nija-at nija-at removed the @aws-cdk/aws-lambda Related to AWS Lambda label Feb 23, 2021
@nija-at nija-at removed their assignment Feb 23, 2021
@iliapolo iliapolo added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Feb 23, 2021
@iliapolo
Copy link
Contributor

Sounds good.

jogold added a commit to jogold/aws-cdk that referenced this issue Feb 24, 2021
@mergify mergify bot closed this as completed in #13266 Mar 1, 2021
mergify bot pushed a commit that referenced this issue Mar 1, 2021
Closes #13223


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-ses Related to Amazon Simple Email Service effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants