fix: incorrect peerDependency on "constructs" #13255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both `@monocdk-experiment/assert` and `aws-cdk-lib` had an outdated peer dependency declaration against `construct` (at `^3.0.4` when the code actually depends on features introduced as recently as `^3.2.0`). This corrects the declaration accordingly. Additionally, fixes the pack prerequisite check for .NET to accept .NET 5.0 as a valid provider for .NET Core 3.1 (because it is).
|
|
RomainMuller
added
pr-linter/exempt-readme
nija-at
reviewed
Feb 24, 2021
nija-at
approved these changes
Feb 24, 2021
eladb
reviewed
Feb 24, 2021
| @@ -47,7 +47,7 @@ | |||
| "@aws-cdk/cloudformation-diff": "0.0.0" | |||
| }, | |||
| "peerDependencies": { | |||
| "constructs": "^3.0.4", | |||
Co-authored-by: Niranjan Jayakar <nija@amazon.com>
RomainMuller
removed
the
pr/do-not-merge
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both
@monocdk-experiment/assertandaws-cdk-libhad an outdated peerdependency declaration against
construct(at^3.0.4when the codeactually depends on features introduced as recently as
^3.2.0). Thiscorrects the declaration accordingly.
Additionally, fixes the pack prerequisite check for .NET to accept
.NET 5.0 as a valid provider for .NET Core 3.1 (because it is).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license