Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: incorrect peerDependency on "constructs" #13255

Merged
merged 7 commits into from
Feb 25, 2021
Merged

fix: incorrect peerDependency on "constructs" #13255

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
e372669
fix: incorrect peerDependency on "constructs"
RomainMuller Feb 24, 2021
e18dbe2
add pkglint rule
RomainMuller Feb 24, 2021
b0279a9
Merge branch 'master' into rmuller/upgrade-constructs
RomainMuller Feb 24, 2021
e338f18
Update tools/pkglint/lib/rules.ts
RomainMuller Feb 25, 2021
a5928df
Update tools/pkglint/lib/rules.ts
RomainMuller Feb 25, 2021
dde3042
Merge branch 'master' into rmuller/upgrade-constructs
RomainMuller Feb 25, 2021
4c79bed
Merge branch 'master' into rmuller/upgrade-constructs
mergify[bot] Feb 25, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/@monocdk-experiment/assert/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@
"@aws-cdk/cloudformation-diff": "0.0.0"
},
"peerDependencies": {
"constructs": "^3.0.4",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We normally recommend to declare a pinned devDependency in order to ensure that the code gets tested with the minimal version required by the peer. Is this not the case here? Why?

Copying @nija-at and @NetaNir whom
I talked to about this.

"constructs": "^3.2.0",
RomainMuller marked this conversation as resolved.
Show resolved Hide resolved
"jest": "^26.6.3",
"monocdk": "^0.0.0"
},
Expand Down
2 changes: 1 addition & 1 deletion packages/aws-cdk-lib/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,7 +293,7 @@
"ubergen": "0.0.0"
},
"peerDependencies": {
"constructs": "^3.0.4"
"constructs": "^3.2.0"
},
"homepage": "https://github.com/aws/aws-cdk",
"engines": {
Expand Down
12 changes: 6 additions & 6 deletions scripts/check-pack-prerequisites.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,12 +54,12 @@ app_v=$(${app} -version 2>&1)
echo -e "Checking javac version... \c"
# 1.8
if [ $(echo $app_v | grep -c -E "1\.8\.[0-9].*") -eq 1 ]
then
then
echo "Ok"
else
# 11 or 14 or 15
if [ $(echo $app_v | grep -c -E "1[145]\.[0-9]\.[0-9].*") -eq 1 ]
then
then
echo "Ok"
else
wrong_version
Expand All @@ -73,7 +73,7 @@ check_which $app $app_min
app_v=$(${app} --version)
echo -e "Checking mvn version... \c"
if [ $(echo $app_v | grep -c -E "3\.[6789]\.[0-9].*") -eq 1 ]
then
then
echo "Ok"
else
wrong_version
Expand All @@ -85,8 +85,8 @@ app_min="3.1.0"
check_which $app $app_min
app_v=$(${app} --version)
echo -e "Checking $app version... \c"
if [ $(echo $app_v | grep -c -E "3\.1\.[0-9].*") -eq 1 ]
then
if [ $(echo $app_v | grep -c -E "3\.1\.[0-9].*|[4-9]\..*") -eq 1 ]
then
echo "Ok"
else
wrong_version
Expand All @@ -99,7 +99,7 @@ check_which $app $app_min
app_v=$(${app} --version)
echo -e "Checking $app version... \c"
if [ $(echo $app_v | grep -c -E "3\.[6789]\.[0-9].*") -eq 1 ]
then
then
echo "Ok"
else
wrong_version
Expand Down