Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-stepfunctions): Validate StateMachine name #13289

Closed
1 of 2 tasks
Assignees
Labels
@aws-cdk/aws-stepfunctions Related to AWS StepFunctions effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p1

Comments

@jonnekaunisto
Copy link
Contributor

jonnekaunisto commented Feb 25, 2021

There are a couple of constraints on StateMachine name. Those should be validated when creating the CloudFormation template.

Here are the constraints: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-stepfunctions-statemachine.html#cfn-stepfunctions-statemachine-statemachinename

In addition there is also length constraint, which is not specified in Cfn documentation: https://docs.aws.amazon.com/step-functions/latest/apireference/API_CreateStateMachine.html#StepFunctions-CreateStateMachine-request-name

Use Case

Catching errors before deploying

Proposed Solution

if (!validName(name)) {
throw Error
}
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@jonnekaunisto jonnekaunisto added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Feb 25, 2021
@github-actions github-actions bot added the @aws-cdk/aws-stepfunctions Related to AWS StepFunctions label Feb 25, 2021
@shivlaks shivlaks added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 3, 2021
jonnekaunisto added a commit to jonnekaunisto/aws-cdk that referenced this issue Mar 4, 2021
@mergify mergify bot closed this as completed in #13387 Mar 9, 2021
mergify bot pushed a commit that referenced this issue Mar 9, 2021
closes #13289


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Mar 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

This was referenced Mar 12, 2021
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment