Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

"cdk diff" does not show old and new values when a property changes #133

Closed
eladb opened this issue Jun 19, 2018 · 0 comments · Fixed by #136
Closed

"cdk diff" does not show old and new values when a property changes #133

eladb opened this issue Jun 19, 2018 · 0 comments · Fixed by #136
Assignees
@RomainMuller
Labels
bug This issue is a bug.

Comments

@eladb
Copy link
Contributor

eladb commented Jun 19, 2018

Repro: in Getting Started, follow the guide until you reach the "cdk diff" stage.

The output is expected to be:

[~] 🛠 Updating MyQueueE6CA6235 (type: AWS::SQS::Queue)
 └─ [~] .VisibilityTimeout:
    └─ Old value: 300
    └─ New value: 500

But the output is:

[~] 🛠 Updating MyQueueE6CA6235 (type: AWS::SQS::Queue)
 └─ [~] .VisibilityTimeout:
@RomainMuller RomainMuller added the bug This issue is a bug. label Jun 19, 2018
RomainMuller added a commit that referenced this issue Jun 19, 2018
@RomainMuller
Have cdk diff output render 'number' value changes
801c723 
Number value changes did not benefit from the old/new value rendering in the output
of `cdk diff` because 'number' value types were handled with the non-'string'
types.

Fixes #133
@RomainMuller RomainMuller mentioned this issue Jun 19, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@RomainMuller RomainMuller

Labels
bug This issue is a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Have cdk diff output render 'number' value changes aws/aws-cdk
2 participants
@RomainMuller @eladb