Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

toolkit: include "engines" in package.json #1337

Closed
eladb opened this issue Dec 12, 2018 · 0 comments · Fixed by #1358
Closed

toolkit: include "engines" in package.json #1337

eladb opened this issue Dec 12, 2018 · 0 comments · Fixed by #1358
Assignees
@rix0rrr
Labels
feature-request A feature should be added or improved.

Comments

@eladb
Copy link
Contributor

eladb commented Dec 12, 2018

Include "engines" with minimal node.js version we require in the engines field of aws-cdk so that installation will fail if there's an older node version.

Credits: @thomasdeml
@rix0rrr rix0rrr self-assigned this Dec 13, 2018
rix0rrr pushed a commit that referenced this issue Dec 13, 2018
feat: add "engines.node" key to all packages
0e8ba1f 
This will make NPM throw an error if users try to install any of
the packages on an incompatible version of NodeJS.

Fixes #1337.
@rix0rrr rix0rrr mentioned this issue Dec 13, 2018
Merged
9 tasks
rix0rrr added a commit that referenced this issue Dec 13, 2018
@rix0rrr
feat: add "engines.node" key to all packages (#1358)
b595cf0 
This will make NPM throw an error if users try to install any of
the packages on an incompatible version of NodeJS.

Fixes #1337.
@srchase srchase added feature-request A feature should be added or improved. and removed enhancement labels Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

Labels
feature-request A feature should be added or improved.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: add "engines.node" key to all packages aws/aws-cdk
4 participants
@RomainMuller @rix0rrr @eladb @srchase