-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(iam): SAML identity provider #13393
Conversation
L2 for `AWS::IAM::SAMLProvider`. Also add derived classes for federeted principals.
packages/@aws-cdk/aws-iam/README.md
Outdated
|
||
```ts | ||
const provider = new iam.SamlProvider(this, 'Provider', { | ||
metadataDocument: fs.readFileSync('/path/to/saml-metadata-document.xml', 'utf-8'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we abstract this away? I don't think anybody would want to inline the XML and read from a file would be the default. So what about providing only a file name to the L2?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In most cases you are right but it could be returned by a custom resource?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So what about a SamlMetadata class that has fromInline and fromFile?
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
L2 for [`AWS::IAM::SAMLProvider`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-samlprovider.html). Also add derived classes for federated principals. Closes aws#5320 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
L2 for
AWS::IAM::SAMLProvider
.Also add derived classes for federated principals.
Closes #5320
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license