Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(iam): SAML identity provider #13393

Merged
merged 4 commits into from
Mar 8, 2021
Merged

Conversation

jogold
Copy link
Contributor

@jogold jogold commented Mar 4, 2021

L2 for AWS::IAM::SAMLProvider.

Also add derived classes for federated principals.

Closes #5320


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

L2 for `AWS::IAM::SAMLProvider`.

Also add derived classes for federeted principals.
@gitpod-io
Copy link

gitpod-io bot commented Mar 4, 2021

@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Mar 4, 2021

```ts
const provider = new iam.SamlProvider(this, 'Provider', {
metadataDocument: fs.readFileSync('/path/to/saml-metadata-document.xml', 'utf-8'),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we abstract this away? I don't think anybody would want to inline the XML and read from a file would be the default. So what about providing only a file name to the L2?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In most cases you are right but it could be returned by a custom resource?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So what about a SamlMetadata class that has fromInline and fromFile?

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: d68fadb
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Mar 8, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit faa0c06 into aws:master Mar 8, 2021
@jogold jogold deleted the iam-saml-provider branch March 8, 2021 15:59
cornerwings pushed a commit to cornerwings/aws-cdk that referenced this pull request Mar 8, 2021
L2 for [`AWS::IAM::SAMLProvider`](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-resource-iam-samlprovider.html).

Also add derived classes for federated principals.

Closes aws#5320


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
This was referenced Mar 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement an L2 for SAML providers
4 participants