aws-chatbot: addXXXPermisions() does not work

[aqilzeeshan]

Reproduction Steps

What did you expect to happen?

According to https://docs.aws.amazon.com/cdk/api/latest/docs/aws-chatbot-readme.html the following should work

slackChannel.addLambdaInvokeCommandPermissions();
slackChannel.addNotificationPermissions();
slackChannel.addSupportCommandPermissions();
slackChannel.addReadOnlyCommandPermissions();

What actually happened?

Environment

• **CDK CLI Version :*1.91.0 *
• **Framework Version:*1.91.0 *
• **Node.js Version:v10.24.0
• **OS :Amazon Linux AMI 2018.03
• **Language (Version):TypeScript Version 3.7.5

Other

Of course I can do it long way as shown below but it would be nice to reduce lines of code if above works.

    const lambdaInvokeCommandStatement = new iam.PolicyStatement({
      effect: iam.Effect.ALLOW,
      resources: ['*'],
      actions: [
        "lambda:invokeAsync",
        "lambda:invokeFunction"
      ],
    });
    slackChannel.addToRolePolicy(lambdaInvokeCommandStatement);

---

This is 🐛 Bug Report

[OG84]

yep just noticed the same. Documentation seems not to be in sync.
This was never implemented, if I read the pull request correctly.

[skinny85]

Hey @aqilzeeshan ,

yes, this is an error in the documentation. These were removed from the original PR, in favor of just having the addToRolePolicy method.

Any chance of a PR fixing the docs? Here's our Contributing guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

[BLasan]

Hey @aqilzeeshan ,

yes, this is an error in the documentation. These were removed from the original PR, in favor of just having the addToRolePolicy method.

Any chance of a PR fixing the docs? Here's our Contributing guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md.

Thanks,
Adam

Can I work on this? Basically we need to replace slackChannel.addLambdaInvokeCommandPermissions(); with slackChannel.addToRolePolicy(lambdaInvokeCommandStatement); right?

[MrArnoldPalmer]

@BLasan whoever wants to pick it is welcome. Yeah it's just replacing references in the docs to the old methods with usage of addToResourcePolicy.

[BLasan]

@MrArnoldPalmer So I need to do the change in awsdocs/aws-cdk-guide right?

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.