-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
aws-chatbot: addXXXPermisions() does not work #13444
Comments
yep just noticed the same. Documentation seems not to be in sync. |
Hey @aqilzeeshan , yes, this is an error in the documentation. These were removed from the original PR, in favor of just having the Any chance of a PR fixing the docs? Here's our Contributing guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md. Thanks, |
Can I work on this? Basically we need to replace |
@BLasan whoever wants to pick it is welcome. Yeah it's just replacing references in the docs to the old methods with usage of addToResourcePolicy. |
@MrArnoldPalmer So I need to do the change in awsdocs/aws-cdk-guide right? |
…Permissions with addToPolicy fixes: aws#13444
…README.md (#13521) Currently addLambdaInvokeCommandPermissions method used to get the permissions, which is a deprecated method now. Use addToPolicy method to get necessary permissions fix: #13444 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Reproduction Steps
What did you expect to happen?
According to https://docs.aws.amazon.com/cdk/api/latest/docs/aws-chatbot-readme.html the following should work
What actually happened?
Environment
Other
Of course I can do it long way as shown below but it would be nice to reduce lines of code if above works.
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: