Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(events): specifying a schedule duration in seconds results in an error #13566

Closed
andrestone opened this issue Mar 12, 2021 · 2 comments · Fixed by #13689
Closed

(events): specifying a schedule duration in seconds results in an error #13566

andrestone opened this issue Mar 12, 2021 · 2 comments · Fixed by #13689
Assignees
@rix0rrr @nija-at
Labels
@aws-cdk/aws-events Related to CloudWatch Events bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@andrestone
Copy link
Contributor

❓ General Issue

This PR breaks Schedule.rule() in aws-events. Previously it was possible to define a Duration in seconds, now it throws an error.
@andrestone andrestone added guidance Question that needs advice or information. needs-triage This issue or PR still needs to be triaged. labels Mar 12, 2021
@github-actions github-actions bot added the @aws-cdk/aws-events Related to CloudWatch Events label Mar 12, 2021
@rix0rrr rix0rrr assigned nija-at and unassigned rix0rrr Mar 15, 2021
@nija-at nija-at added bug This issue is a bug. and removed guidance Question that needs advice or information. labels Mar 17, 2021
@nija-at nija-at changed the title (aws-events): breaking change not present in the release notes (events): specifying a schedule duration in seconds results in an error Mar 19, 2021
nija-at pushed a commit that referenced this issue Mar 19, 2021
fix(events,applicationautoscaling): specifying a schedule rate in sec…
ca18f9d 
…onds results in an error

A previous change - b1449a1 - introduced a validation that should have
been applied only when Duration is specified as a token. Instead, it was
applied for non token values as well.

Adjusting the validation so it only applies to when the duration is a
token.

fixes #13566
@nija-at nija-at mentioned this issue Mar 19, 2021
Merged
@nija-at
Copy link
Contributor

nija-at commented Mar 19, 2021

Thanks for filing this @andrestone.

This was never intended to be a breaking change, and hence was not added to the changelog.
I've re-classified this as a bug and have prepared a fix for this - #13689

@nija-at nija-at added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Mar 19, 2021
@mergify mergify bot closed this as completed in #13689 Mar 22, 2021
mergify bot pushed a commit that referenced this issue Mar 22, 2021
fix(events,applicationautoscaling): specifying a schedule rate in sec…
5d62331 
…onds results in an error (#13689)

A previous change - b1449a1 - introduced a validation that should have
been applied only when Duration is specified as a token. Instead, it was
applied for non token values as well.

Adjusting the validation so it only applies to when the duration is a
token.

fixes #13566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

nija-at pushed a commit that referenced this issue Mar 23, 2021
fix(events,applicationautoscaling): specifying a schedule rate in sec…
4d63482 
…onds results in an error (#13689)

A previous change - b1449a1 - introduced a validation that should have
been applied only when Duration is specified as a token. Instead, it was
applied for non token values as well.

Adjusting the validation so it only applies to when the duration is a
token.

fixes #13566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
eladb pushed a commit that referenced this issue Mar 24, 2021
fix(events,applicationautoscaling): specifying a schedule rate in sec…
b1e1c4d 
…onds results in an error (#13689)

A previous change - b1449a1 - introduced a validation that should have
been applied only when Duration is specified as a token. Instead, it was
applied for non token values as well.

Adjusting the validation so it only applies to when the duration is a
token.

fixes #13566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@hollanddd
fix(events,applicationautoscaling): specifying a schedule rate in sec…
276ac8a 
…onds results in an error (aws#13689)

A previous change - b1449a1 - introduced a validation that should have
been applied only when Duration is specified as a token. Instead, it was
applied for non token values as well.

Adjusting the validation so it only applies to when the duration is a
token.

fixes aws#13566


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rix0rrr rix0rrr

@nija-at nija-at

Labels
@aws-cdk/aws-events Related to CloudWatch Events bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
Milestone
No milestone
3 participants
@rix0rrr @andrestone @nija-at