Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-ecs): bug in sample code in the "Include a classic load balancer" section #13583

Closed
nakaakist opened this issue Mar 14, 2021 · 1 comment · Fixed by #13627
Closed

(aws-ecs): bug in sample code in the "Include a classic load balancer" section #13583

nakaakist opened this issue Mar 14, 2021 · 1 comment · Fixed by #13627
Assignees
Labels
documentation This is a problem with documentation.

Comments

@nakaakist
Copy link

https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecs-readme.html#include-a-classic-load-balancer

The last part of second sample code reads:

lb.addTarget(service.loadBalancerTarget{
  containerName: 'MyContainer',
  containerPort: 80
});

However, it should be

lb.addTarget(service.loadBalancerTarget({
  containerName: 'MyContainer',
  containerPort: 80
}));

This is a 📕 documentation issue

@nakaakist nakaakist added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 14, 2021
@SoManyHs SoManyHs assigned SoManyHs and unassigned ghost Mar 16, 2021
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue Mar 16, 2021
@SoManyHs SoManyHs removed feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 16, 2021
SoManyHs added a commit to SoManyHs/aws-cdk that referenced this issue Mar 16, 2021
@mergify mergify bot closed this as completed in #13627 Mar 17, 2021
mergify bot pushed a commit that referenced this issue Mar 17, 2021
Closes #13583


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Mar 17, 2021
Closes aws#13583


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Mar 18, 2021
Closes aws#13583


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Closes aws#13583


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation This is a problem with documentation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants