Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(neptune): grantConnect() creates incorrect resource ARN #13640

Closed
christophgysin opened this issue Mar 17, 2021 · 1 comment · Fixed by #13641
Closed

(neptune): grantConnect() creates incorrect resource ARN #13640

christophgysin opened this issue Mar 17, 2021 · 1 comment · Fixed by #13641
Assignees
Labels
@aws-cdk/aws-neptune Related Amazon Neptune bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@christophgysin
Copy link
Contributor

When using cluster.grantConnect() on a Neptune cluster, the created IAM statement uses an incorrect ARN.

Reproduction Steps

const cluster = new neptune.DatabaseCluster(this, 'Cluster', {
  vpc,
  instanceType: neptune.InstanceType.T3_MEDIUM,
});
const role = new iam.Role(this, 'DBRole', { assumedBy: new iam.AccountPrincipal(this.account) });
cluster.grantConnect(role);

What did you expect to happen?

DBRole is allowed to connect.

What actually happened?

DBRole is not allowed to connect.

Environment

  • CDK CLI Version: 1.94.1
  • Framework Version: 1.94.1
  • Node.js Version: v14.16.0
  • OS: linux
  • Language (Version): all

This is 🐛 Bug Report

@christophgysin christophgysin added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 17, 2021
@github-actions github-actions bot added the @aws-cdk/aws-neptune Related Amazon Neptune label Mar 17, 2021
christophgysin added a commit to christophgysin/aws-cdk that referenced this issue Mar 17, 2021
@mergify mergify bot closed this as completed in #13641 Mar 18, 2021
mergify bot pushed a commit that referenced this issue Mar 18, 2021
fixes #13640


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

eladb pushed a commit that referenced this issue Mar 24, 2021
fixes #13640


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
fixes aws#13640


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-neptune Related Amazon Neptune bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants