Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(codedeploy): Invalid yum package name causing command failures. #13654

Closed
diegotry opened this issue Mar 18, 2021 · 2 comments
Closed

(codedeploy): Invalid yum package name causing command failures. #13654

diegotry opened this issue Mar 18, 2021 · 2 comments
Assignees
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.

Comments

@diegotry
Copy link
Contributor

The userdata script includes the following command:

yum install -y awscli

The problem is that awscli works for apt-get, but it doesn't work for yum. The correct package name is aws-cli.

The above command returns a code different than 0, which causes the script to fail due to a recent change: see #12764

Previously, the error was ignored and now it is causing failures (which is the right behavior in my opinion, as the package doesn't exist).

Reproduction Steps

sh-4.2$ sudo yum install -y awscli
sh-4.2$ echo $?
130
sh-4.2$ sudo yum install -y aws-cli
Failed to set locale, defaulting to C
Loaded plugins: priorities, update-motd, upgrade-helper
Package aws-cli-1.18.107-1.55.amzn1.noarch already installed and latest version
Nothing to do
sh-4.2$ echo $?
0

What did you expect to happen?

I expect the command to succeed.

What actually happened?

The failure caused my deployments to fail.

Environment

  • CDK CLI Version : latest
  • Framework Version:
  • Node.js Version: 12
  • OS : Amazon Linux
  • Language (Version): Typescript

Other

I will submit a PR soon.


This is 🐛 Bug Report

@diegotry diegotry added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Mar 18, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codedeploy Related to AWS CodeDeploy label Mar 18, 2021
diegotry added a commit to diegotry/aws-cdk that referenced this issue Mar 18, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: aws#13654
mergify bot pushed a commit that referenced this issue Mar 18, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: #13654


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@skinny85
Copy link
Contributor

Fixed in #13655.

@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

eladb pushed a commit that referenced this issue Mar 24, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: #13654


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Package name for yum is not awscli. This causes the command to have a return code different than 0, which fails the user-data script.

This change addresses the issue: aws#13654


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codedeploy Related to AWS CodeDeploy bug This issue is a bug. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Development

No branches or pull requests

2 participants