(aws-codepipeline-actions): Type 'string' is not assignable to type 'S3EventSelector'.

[niklaswallerstedt]

Docs
(CDK v1.94.1)
https://docs.aws.amazon.com/cdk/api/latest/docs/aws-codepipeline-actions-readme.html#aws-s3-source

Using the example for setting up CloudTrail with CloudWatch Events to trigger a pipeline produces:

Type 'string' is not assignable to type 'S3EventSelector'.

trail.addS3EventSelector([sourceBucket.arnForObjects(key)], {
      ...
    });

Working with:

trail.addS3EventSelector([{
      bucket: sourceBucket,
      objectPrefix: key
    }], {
      ...
    });

---

This is a 📕 documentation issue

[skinny85]

Thanks for reporting @niklaswallerstedt ! Any chance of a PR fixing this? Our contribution guide: https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md. The offending example is here: https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-codepipeline-actions/README.md#aws-s3-source

Thanks,
Adam

[BLasan]

@skinny85 Shall I work on this?

[niklaswallerstedt]

@skinny85 made the change, noticed that the readme was missing fixtures though @BLasan

[BLasan]

@skinny85 made the change, noticed that the readme was missing fixtures though @BLasan

Hope your PR completely will fix this issue. :)

[github-actions]

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.