Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-iam): Validate Role path at build time. #13747

Closed
2 tasks
rcollette opened this issue Mar 22, 2021 · 2 comments · Fixed by #16165
Closed
2 tasks

(aws-iam): Validate Role path at build time. #13747

rcollette opened this issue Mar 22, 2021 · 2 comments · Fixed by #16165
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@rcollette
Copy link
Contributor

The path of a Role should be validated at build time such as the fact that a leading slash is required along with the valid character types.

Use Case

To prevent wasted developer time. Deployments take a while to run and this slows down iteration.

Proposed Solution

Self explanatory.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@rcollette rcollette added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Mar 22, 2021
@github-actions github-actions bot added the @aws-cdk/aws-iam Related to AWS Identity and Access Management label Mar 22, 2021
@rix0rrr
Copy link
Contributor

rix0rrr commented Mar 30, 2021

Sounds good.

@rix0rrr rix0rrr added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 labels Mar 30, 2021
@ryparker ryparker removed the needs-triage This issue or PR still needs to be triaged. label Jun 1, 2021
@rix0rrr rix0rrr removed their assignment Jun 3, 2021
@i05nagai i05nagai mentioned this issue Aug 22, 2021
Merged
@mergify mergify bot closed this as completed in #16165 May 13, 2022
mergify bot pushed a commit that referenced this issue May 13, 2022
@i05nagai
feat(iam): validate role path at build time (#16165)
65a5a46 
Role paths can be validated at build time.

According to the [API document](https://docs.aws.amazon.com/IAM/latest/APIReference/API_Role.html), `u007F`, DELETE special char, is valid. However, the creation with a role path `/\u007F/` fails due to validation failure. I don't see any use case for the special char, so I ignored the discrepancy.

closes #13747


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

wphilipw pushed a commit to wphilipw/aws-cdk that referenced this issue May 23, 2022
@i05nagai @wphilipw
feat(iam): validate role path at build time (aws#16165)
940e928 
Role paths can be validated at build time.

According to the [API document](https://docs.aws.amazon.com/IAM/latest/APIReference/API_Role.html), `u007F`, DELETE special char, is valid. However, the creation with a role path `/\u007F/` fails due to validation failure. I don't see any use case for the special char, so I ignored the discrepancy.

closes aws#13747


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-iam Related to AWS Identity and Access Management effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(iam): validate role path at build time i05nagai/aws-cdk
3 participants
@rcollette @rix0rrr @ryparker