-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(aws-stepfunctions): State machine does not allow token in its name #13912
Labels
@aws-cdk/aws-stepfunctions
Related to AWS StepFunctions
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
Comments
supergillis
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Mar 31, 2021
github-actions
bot
added
the
@aws-cdk/aws-stepfunctions
Related to AWS StepFunctions
label
Mar 31, 2021
supergillis
changed the title
(stepfunctions): State machine does not allow token in its name
(aws-stepfunctions): State machine does not allow token in its name
Mar 31, 2021
mergify bot
pushed a commit
that referenced
this issue
Apr 8, 2021
…re used. (#13970) Name validation for state machines was added in #13387. The validation added was not considering that the name may contain an unresolved token. This change skips name validation if there is an unresolved token as it does not make sense to attempt to validate something that is unknown. This change also allows a few more special characters as they are allowed through the AWS Console. fixes #13946 #13912 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this issue
Aug 26, 2021
…re used. (aws#13970) Name validation for state machines was added in aws#13387. The validation added was not considering that the name may contain an unresolved token. This change skips name validation if there is an unresolved token as it does not make sense to attempt to validate something that is unknown. This change also allows a few more special characters as they are allowed through the AWS Console. fixes aws#13946 aws#13912 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
@aws-cdk/aws-stepfunctions
Related to AWS StepFunctions
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
It's not possible to have a token in a state machine name after upgrading from CDK v1.91.0 to v1.95.1.
Reproduction Steps
What did you expect to happen?
The state machine should be created with the name of the stack plus
-Machine
.What actually happened?
The following error occured:
Environment
Other
Introduced in PR #13387.
Validate that the state machine name is not a token and then perform the validation.
aws-cdk/packages/@aws-cdk/aws-stepfunctions/lib/state-machine.ts
Line 434 in ed2bbe6
The following workaround can be used temporarily.
This is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: