Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(neptune): InstanceType needs to be a class with an InstanceType.fromString(...) method #13923

Closed
2 tasks done
zxkane opened this issue Apr 1, 2021 · 1 comment · Fixed by #14273
Closed
2 tasks done

(neptune): InstanceType needs to be a class with an InstanceType.fromString(...) method #13923

zxkane opened this issue Apr 1, 2021 · 1 comment · Fixed by #14273
Assignees
@njlynch
Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2

Comments

@zxkane
Copy link
Contributor

zxkane commented Apr 1, 2021 •
edited
Loading

The instance type of Neptune is strong type InsatnceType, it’s not possible specifying the instance type by CloudFormation parameter given by the customer in deployment time.

Use Case

Use CfnParameter value as the instance type that’s specified by the customer in deployment time.

Proposed Solution

Use the type as InstanceType | string

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@zxkane zxkane added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 1, 2021
@github-actions github-actions bot added @aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-neptune Related Amazon Neptune labels Apr 1, 2021
@rix0rrr rix0rrr changed the title (neptune): specify the instance type by cloudformation parameter (neptune): InstanceType needs to be a class with an InstanceType.fromString(...) method Apr 6, 2021
@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p2 labels Apr 6, 2021
@rix0rrr rix0rrr removed their assignment Apr 6, 2021
@zxkane zxkane mentioned this issue Apr 20, 2021
Merged
@mergify mergify bot closed this as completed in #14273 Apr 27, 2021
mergify bot pushed a commit that referenced this issue Apr 27, 2021
@zxkane
feat(neptune): change InstanceType to class that is built from string (…
fc618f9 
…#14273)

closes #13923

BREAKING CHANGE: `InstanceType` changed from enum to enum-like static factory.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

john-tipper pushed a commit to john-tipper/aws-cdk that referenced this issue May 10, 2021
@zxkane @john-tipper
feat(neptune): change InstanceType to class that is built from string (…
34eef8b 
…aws#14273)

closes aws#13923

BREAKING CHANGE: `InstanceType` changed from enum to enum-like static factory.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@zxkane @hollanddd
feat(neptune): change InstanceType to class that is built from string (…
b90ed35 
…aws#14273)

closes aws#13923

BREAKING CHANGE: `InstanceType` changed from enum to enum-like static factory.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-cloudformation Related to AWS CloudFormation @aws-cdk/aws-neptune Related Amazon Neptune effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(neptune): change InstanceType to class that is built from string zxkane/aws-cdk
3 participants
@rix0rrr @zxkane @njlynch