Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elasticloadbalancingv2): cant set grpc code matcher on alb #13947

Closed
1 task done
ChristopheBougere opened this issue Apr 1, 2021 · 1 comment · Fixed by #13948
Closed
1 task done

(elasticloadbalancingv2): cant set grpc code matcher on alb #13947

ChristopheBougere opened this issue Apr 1, 2021 · 1 comment · Fixed by #13948
Assignees
@njlynch
Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.

Comments

@ChristopheBougere
Copy link
Contributor

With #13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC.
However, it is not yet possible to define a GrpcCode for the matcher (see CloudFormation doc).

Use Case

Being able to define a custom GRPC Code for the matcher, like for HTTP Code

Proposed Solution

Add a healthyGrpcCodes working the same way as healthyHttpCodes.

  • 👋 I may be able to implement this feature request

This is a 🚀 Feature Request
@ChristopheBougere ChristopheBougere added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Apr 1, 2021
@ChristopheBougere ChristopheBougere mentioned this issue Apr 1, 2021
Merged
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 label Apr 1, 2021
@mergify mergify bot closed this as completed in #13948 Apr 6, 2021
mergify bot pushed a commit that referenced this issue Apr 6, 2021
@ChristopheBougere
feat(elasticloadbalancingv2): add grpc code matcher for alb (#13948)
a37f178 
With #13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC.
However, it is not yet possible to define a GrpcCode for the matcher (see [CloudFormation doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-matcher.html)).

I added a `healthyGrpcCodes` working the same way as `healthyHttpCodes`.

closes #13947

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Apr 6, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@ChristopheBougere @hollanddd
feat(elasticloadbalancingv2): add grpc code matcher for alb (aws#13948)
9193f99 
With aws#13570, it is now possible to set the protocol version for ALB target groups, and thus make it working for GRPC.
However, it is not yet possible to define a GrpcCode for the matcher (see [CloudFormation doc](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-elasticloadbalancingv2-targetgroup-matcher.html)).

I added a `healthyGrpcCodes` working the same way as `healthyHttpCodes`.

closes aws#13947

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@njlynch njlynch

Labels
@aws-cdk/aws-elasticloadbalancingv2 Related to Amazon Elastic Load Balancing V2 feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elasticloadbalancingv2): add grpc code matcher for alb
2 participants
@ChristopheBougere @njlynch