Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-stepfunction-tasks): CallApiGatewayHttpApiEndpoint didn't include "Stage" during rend the object #14242

Closed
linguohan opened this issue Apr 19, 2021 · 1 comment · Fixed by #15755
Labels
@aws-cdk/aws-stepfunctions-tasks bug This issue is a bug. effort/small Small work item – less than a day of effort p1

Comments

@linguohan
Copy link

linguohan commented Apr 19, 2021

CallApiGatewayHttpApiEndpoint didn't include "Stage" during rend the object after set stageName.

Reproduction Steps

new sfn_tasks.CallApiGatewayHttpApiEndpoint(this, "call ApiGateway HttpApi Endpoint", {
    api: HttpApi.fromHttpApiAttributes(this, "call ApiGateway HttpApi Endpoint ", { httpApiId: http_api_id}),
    stageName: "Alpha",
    apiPath: "/apitPath",
    heartbeat: cdk.Duration.seconds(10),
    integrationPattern: sfn.IntegrationPattern.REQUEST_RESPONSE,
    method: sfn_tasks.HttpMethod.POST,
    timeout: cdk.Duration.minutes(2),
    authType: sfn_tasks.AuthType.IAM_ROLE,
});

What did you expect to happen?

Should include the Stage in the Step function State machines.

What actually happened?

Didn't include the Stage in the Step function State machines.

Environment

  • CDK CLI Version : mono CDK 1.97.0
  • Framework Version:
  • Node.js Version: v12.5.0
  • OS :
  • Language (Version): TypeScript

Other

May need to use the

Stage: this.baseProps.stageName

in https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-stepfunctions-tasks/lib/apigateway/base.ts#L48
As we didn't set the stage like we did in CallApiGatewayRestApiEndpoint.

See
https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-stepfunctions-tasks/lib/apigateway/call-rest-api.ts#L42

and

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-stepfunctions-tasks/lib/apigateway/call-http-api.ts#L36-L45


This is 🐛 Bug Report

@linguohan linguohan added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Apr 19, 2021
@shivlaks shivlaks added p1 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels May 24, 2021
@mergify mergify bot closed this as completed in #15755 Jul 30, 2021
mergify bot pushed a commit that referenced this issue Jul 30, 2021
…ttpApiEndpoint task definition (#15755)

`this.stageName` was not initialized by `props.stageName` when calling `CallApiGatewayHttpApiEndpoint`'s constructor, therefore causing the `Stage` field to not get rendered even though we specified that property.

fixes #14242

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
…ttpApiEndpoint task definition (aws#15755)

`this.stageName` was not initialized by `props.stageName` when calling `CallApiGatewayHttpApiEndpoint`'s constructor, therefore causing the `Stage` field to not get rendered even though we specified that property.

fixes aws#14242

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
…ttpApiEndpoint task definition (aws#15755)

`this.stageName` was not initialized by `props.stageName` when calling `CallApiGatewayHttpApiEndpoint`'s constructor, therefore causing the `Stage` field to not get rendered even though we specified that property.

fixes aws#14242

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-stepfunctions-tasks bug This issue is a bug. effort/small Small work item – less than a day of effort p1
Projects
None yet
3 participants