-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(autoscaling): add getter/setter for instance termination protection #14308
feat(autoscaling): add getter/setter for instance termination protection #14308
Conversation
I'm also OK with just making the property readable/writable instead of using a getter/setter, but I believe writable properties aren't really idiomatic in CDK. Happy to go in whichever direction you like. |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ion (aws#14308) Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled. This is a follow up to aws#14283. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ion (aws#14308) Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled. This is a follow up to aws#14283. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled.
This is a follow up to #14283.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license