Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(aws-autoscaling): add support for NewInstancesProtectedFromScaleIn #14283

Merged
merged 4 commits into from
Apr 21, 2021

Conversation

otterley
Copy link
Contributor

Add support for NewInstancesProtectedFromScaleIn. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers.


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@gitpod-io
Copy link

gitpod-io bot commented Apr 20, 2021

@github-actions github-actions bot added the @aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling label Apr 20, 2021
@otterley otterley force-pushed the autoscaling-protect-scale-in branch 4 times, most recently from 9b39aa4 to 9a98ae6 Compare April 20, 2021 22:49
@NetaNir NetaNir assigned rix0rrr and unassigned NetaNir Apr 20, 2021
@otterley otterley force-pushed the autoscaling-protect-scale-in branch from 9a98ae6 to 99cea06 Compare April 20, 2021 23:25
Copy link
Contributor

@rix0rrr rix0rrr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see how this feature is ever going to work well or lead to a good experience in desired-state IaC... but it seems like a trivial addition of something exposed in CloudFormation, so approved I guess.

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added the pr-linter/exempt-readme The PR linter will not require README changes label Apr 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@rix0rrr rix0rrr added pr/do-not-merge This PR should not be merged at this time. and removed pr/do-not-merge This PR should not be merged at this time. labels Apr 21, 2021
@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: e561330
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify
Copy link
Contributor

mergify bot commented Apr 21, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit da9828b into aws:master Apr 21, 2021
mergify bot pushed a commit that referenced this pull request Apr 28, 2021
…ion (#14308)

Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled.

This is a follow up to #14283.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
…In (aws#14283)

Add support for `NewInstancesProtectedFromScaleIn`. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
john-tipper pushed a commit to john-tipper/aws-cdk that referenced this pull request May 10, 2021
…ion (aws#14308)

Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled.

This is a follow up to aws#14283.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…In (aws#14283)

Add support for `NewInstancesProtectedFromScaleIn`. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this pull request Aug 26, 2021
…ion (aws#14308)

Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled.

This is a follow up to aws#14283.

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-autoscaling Related to Amazon EC2 Auto Scaling pr-linter/exempt-readme The PR linter will not require README changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants