-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(aws-autoscaling): add support for NewInstancesProtectedFromScaleIn #14283
Conversation
9b39aa4
to
9a98ae6
Compare
9a98ae6
to
99cea06
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see how this feature is ever going to work well or lead to a good experience in desired-state IaC... but it seems like a trivial addition of something exposed in CloudFormation, so approved I guess.
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
…ion (#14308) Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled. This is a follow up to #14283. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…In (aws#14283) Add support for `NewInstancesProtectedFromScaleIn`. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ion (aws#14308) Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled. This is a follow up to aws#14283. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…In (aws#14283) Add support for `NewInstancesProtectedFromScaleIn`. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
…ion (aws#14308) Adds getter/setter methods for enabling and querying instance termination protection. This will be used by EC2 Capacity Provider support for ECS to ensure the flag is set correctly when managed termination protection is enabled. This is a follow up to aws#14283. ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Add support for
NewInstancesProtectedFromScaleIn
. This is a prerequisite for a forthcoming enhancement to improve the aws-ecs module so it can leverage EC2 Capacity Providers.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license