Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align docs to changes after AWS construct library renames #1442

Closed
eladb opened this issue Dec 27, 2018 · 3 comments
Closed

Align docs to changes after AWS construct library renames #1442

eladb opened this issue Dec 27, 2018 · 3 comments
Assignees
@Doug-AWS
Labels
docs/guide Related to the developer guide effort/small Small work item – less than a day of effort p0 pr/work-in-progress This PR is a draft and needs further work.

Comments

@eladb
Copy link
Contributor

eladb commented Dec 27, 2018

See #1434
@Doug-AWS
Copy link
Contributor

Doug-AWS commented Jan 2, 2019

I've grepped all the user guide files and it looks like I have to update:

  • XxxRefProps are now XxxImportProps
  • XxxRef.import(...) are now Xxx.import(...) accept XxxImportProps and return IXxx
  • Route53 record classes now require a zone when created (not assuming zone is the parent construct).

@Doug-AWS Doug-AWS added docs/guide Related to the developer guide p0 effort/small Small work item – less than a day of effort labels Jan 23, 2019
@Doug-AWS
Copy link
Contributor

Done. The docs should be live by EOD tomorrow.

@Doug-AWS Doug-AWS self-assigned this Feb 18, 2019
@Doug-AWS Doug-AWS added the pr/work-in-progress This PR is a draft and needs further work. label Feb 21, 2019
@Doug-AWS
Copy link
Contributor

The updated docs are now live: https://docs.aws.amazon.com/CDK/latest/userguide

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Doug-AWS Doug-AWS

Labels
docs/guide Related to the developer guide effort/small Small work item – less than a day of effort p0 pr/work-in-progress This PR is a draft and needs further work.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eladb @Doug-AWS