feat: aws resource api linting (breaking changes)

[eladb]

Fixes #742
Built on top of #1428

BREAKING CHANGE: AWS resource-related classes have been changed to conform to API guidelines:

• XxxRef abstract classes are now IXxx interfaces
• XxxRefProps are now XxxImportProps
• XxxRef.import(...) are now Xxx.import(...) accept XxxImportProps and return IXxx
• export(): XxxImportProps is now defined in IXxx and implemented by imported resources
• Lambda's static "metric" methods moved from lambda.FunctionRef to lambda.Function.
• Route53 record classes now require a zone when created (not assuming zone is the parent construct).

---

Pull Request Checklist

• Testing
  • Unit test added
  • CLI change?: manually run integration tests and paste output as a PR comment
  • cdk-init template change?: coordinated update of integration tests with team
• Docs
  • jsdocs: All public APIs documented
  • README: README and/or documentation topic updated
• Title and Description
  • Change type: title prefixed with fix, feat will appear in changelog
  • Title: use lower-case and doesn't end with a period
  • Breaking?: last paragraph: "BREAKING CHANGE: <describe what changed + link for details>"
  • Issues: Indicate issues fixed via: "Fixes #xxx" or "Closes #xxx"
• Sensitive Modules (requires 2 PR approvers)
  • IAM Policy Document (in @aws-cdk/aws-iam)
  • EC2 Security Groups and ACLs (in @aws-cdk/aws-ec2)
  • Grant APIs (only if not based on official documentation with a reference)

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license.

[rix0rrr]

XxxRefProps interfaces renamed to XxxAttributes.

I find BucketProps vs BucketAttributes somewhat inscrutable. ImportedBucketProps? BucketImportProps?

Implement export in ImportedXxx by simply proxying the passed-in attributes

Not sure that export() needs to be possible on an imported object. I realize that it is possible today, but not sure it's something we need to maintain. We'd need to put export() on IBucket as well to make use of it.

Create XxxBase when appropriate

This can't be private, huh?

[eladb]

I find BucketProps vs BucketAttributes somewhat inscrutable. ImportedBucketProps? BucketImportProps?

I agree that XxxAttributes is not perfect. I think it should begin with Bucket so it will be grouped together with the rest of the resource classes, and I feel XxxxImportProps is just too long and ugly. How about just BucketImport?

Not sure that export() needs to be possible on an imported object. I realize that it is possible today, but not sure it's something we need to maintain.

I think export() is relevant for imported resources. If you have an IBucket in your hands and want to export it so it can be used by other apps/stacks, you don't want to care if it's an internal or external resource.

Create XxxBase when appropriate
This can't be private, huh?

Sadly not. We could come up with some other convoluted way to reuse, but I think this is fine.

[mergify]

Thanks so much for taking the time to contribute to the AWS CDK ❤️

We will shortly assign someone to review this pull request and help get it
merged. In the meantime, please take a minute to make sure you follow this
checklist:

• PR title type(scope): text
  • type: fix, feat, refactor go into CHANGELOG, chore is hidden
  • scope: name of module without aws- or cdk- prefix or postfix (e.g. s3 instead of aws-s3-deployment)
  • text: use all lower-case, do not end with a period, do not include issue refs
• PR Description
  • Rationale: describe rationale of change and approach taken
  • Issues: indicate issues fixed via: fixes #xxx or closes #xxx
  • Breaking?: last paragraph: BREAKING CHANGE: <describe what changed + link for details>
• Testing
  • Unit test added. Prefer to add a new test rather than modify existing tests
  • CLI or init templates change? Re-run/add CLI integration tests
• Documentation
  • README: update module README to describe new features
  • API docs: public APIs must be documented. Copy from official AWS docs when possible
  • Design: for significant features, follow design process