Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(elb) set accessLoggingPolicy property with L2 LoadBalancer #14972

Closed
ramancloudsmartz opened this issue Jun 3, 2021 · 5 comments · Fixed by #14983
Closed

(elb) set accessLoggingPolicy property with L2 LoadBalancer #14972

ramancloudsmartz opened this issue Jun 3, 2021 · 5 comments · Fixed by #14983
Assignees
@peterwoodworth
Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2

Comments

@ramancloudsmartz
Copy link
Contributor

ramancloudsmartz commented Jun 3, 2021 •
edited
Loading

As the elb property readonly private , it has no visibilty outside. Also there is no method to access it. There is no provision to enable access log for LB

https://github.com/aws/aws-cdk/blob/master/packages/%40aws-cdk/aws-elasticloadbalancing/lib/load-balancer.ts
@ramancloudsmartz ramancloudsmartz added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 3, 2021
@ramancloudsmartz ramancloudsmartz changed the title Classic Loadbalacer not allowing to eble accesslogs Classic Loadbalacer not allowing to enable accesslogs Jun 3, 2021
@peterwoodworth peterwoodworth added feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. p2 effort/small Small work item – less than a day of effort labels Jun 3, 2021
@peterwoodworth peterwoodworth changed the title Classic Loadbalacer not allowing to enable accesslogs (elb) set accessLoggingPolicy property with L2 LoadBalancer Jun 3, 2021
@github-actions github-actions bot added the @aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing label Jun 3, 2021
@peterwoodworth peterwoodworth removed the needs-triage This issue or PR still needs to be triaged. label Jun 3, 2021
@peterwoodworth
Copy link
Contributor

Thanks for the feature request! If you want to do something like this immediately using the CDK you can set these same properties in your load balancer using ElbV2 ALB or NLB and using the logAccessLogs method

@ramancloudsmartz
Copy link
Contributor Author

@peterwoodworth I need it with Elb LoadBalancer ( Classic Loadbalancer )

@ramancloudsmartz ramancloudsmartz mentioned this issue Jun 4, 2021
Merged
@ramancloudsmartz
Copy link
Contributor Author

@peterwoodworth Please review PR , I have added tests as well. Please let me know if required any change
Thanks

@ramancloudsmartz
Copy link
Contributor Author

Please review feat(elb): set accessLoggingPolicy property with L2 LoadBalancer #14983

@mergify mergify bot closed this as completed in #14983 Jun 7, 2021
mergify bot pushed a commit that referenced this issue Jun 7, 2021
@ramancloudsmartz
feat(elb): set accessLoggingPolicy property with L2 LoadBalancer (#14983
252dfa2 
)

Using cdk we can enable access logs for elb.Loadbalancer
fixes #14972

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Jun 7, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@ramancloudsmartz @hollanddd
feat(elb): set accessLoggingPolicy property with L2 LoadBalancer (aws…
940619b 
…#14983)

Using cdk we can enable access logs for elb.Loadbalancer
fixes aws#14972

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@peterwoodworth peterwoodworth

Labels
@aws-cdk/aws-elasticloadbalancing Related to Amazon Elastic Load Balancing effort/small Small work item – less than a day of effort feature/enhancement A new API to make things easier or more intuitive. A catch-all for general feature requests. feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(elb): set accessLoggingPolicy property with L2 LoadBalancer ramancloudsmartz/aws-cdk
3 participants
@njlynch @peterwoodworth @ramancloudsmartz