Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(stepfunctions-tasks): PutEvent task #15033

Closed
1 of 2 tasks
Glyphack opened this issue Jun 8, 2021 · 1 comment · Fixed by #15165
Closed
1 of 2 tasks

(stepfunctions-tasks): PutEvent task #15033

Glyphack opened this issue Jun 8, 2021 · 1 comment · Fixed by #15165
Labels
@aws-cdk/aws-events Related to CloudWatch Events @aws-cdk/aws-stepfunctions-tasks effort/large Large work item – several weeks of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p1

Comments

@Glyphack
Copy link

Glyphack commented Jun 8, 2021 •
edited
Loading

I see Task class in aws_stepfunctions is breaking into specific tasks and move to aws_stepfunctions_tasks. and recently eventbridge integration introduced for stepfunctions. I think it's appropriate to have EventBridgePutEvent task here.

Use Case

using stepfunctions integration with EventBridge
https://docs.aws.amazon.com/step-functions/latest/dg/connect-eventbridge.html

Proposed Solution

Implementation should be like other tasks we add tasks.EvenrBridgePutEvent with following properties(I'm not completely familiar with common properties needed):

Entries # https://docs.aws.amazon.com/eventbridge/latest/APIReference/API_PutEvents.html#API_PutEvents_RequestSyntax
  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@Glyphack Glyphack added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 8, 2021
@Glyphack Glyphack changed the title (module name): short issue description (stepfunctions_tasks): PutEvent task Jun 8, 2021
@BenChaimberg BenChaimberg changed the title (stepfunctions_tasks): PutEvent task (stepfunctions-tasks): PutEvent task Jun 8, 2021
@BenChaimberg BenChaimberg mentioned this issue Jun 8, 2021
Closed
3 tasks
@peterwoodworth peterwoodworth added the feature/service-integration Add functionality to an L2 construct to enable easier integration with another service label Jun 8, 2021
@BenChaimberg BenChaimberg added effort/large Large work item – several weeks of effort p1 @aws-cdk/aws-events Related to CloudWatch Events and removed needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2021
@BenChaimberg BenChaimberg removed their assignment Jun 11, 2021
@BenChaimberg BenChaimberg mentioned this issue Jun 17, 2021
Merged
@mergify mergify bot closed this as completed in #15165 Jun 29, 2021
mergify bot pushed a commit that referenced this issue Jun 29, 2021
@Sumeet-Badyal
feat(stepfunctions-tasks): add EventBridgePutEvents task integration (#…
1799f4c 
…15165)

Adds support for EventBridge PutEvents as a Step Functions task integration

closes #15033

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@Sumeet-Badyal @hollanddd
feat(stepfunctions-tasks): add EventBridgePutEvents task integration (a…
dd86b6e 
…ws#15165)

Adds support for EventBridge PutEvents as a Step Functions task integration

closes aws#15033

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-events Related to CloudWatch Events @aws-cdk/aws-stepfunctions-tasks effort/large Large work item – several weeks of effort feature/service-integration Add functionality to an L2 construct to enable easier integration with another service feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
No milestone
3 participants
@BenChaimberg @Glyphack @peterwoodworth