Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(@aws-cdk/aws-sqs): Support configuring high throughput for FIFO queues #15063

Closed
2 tasks
westonsteimel opened this issue Jun 10, 2021 · 4 comments · Fixed by #15202
Closed
2 tasks

(@aws-cdk/aws-sqs): Support configuring high throughput for FIFO queues #15063

westonsteimel opened this issue Jun 10, 2021 · 4 comments · Fixed by #15202
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1

Comments

@westonsteimel
Copy link

High throughput mode on FIFO SQS queues is now generally available, and it would be convenient to be able to configure it via the CDK

Proposed Solution

Allow setting the following queue attributes:

deduplication_scope:

  • MESSAGE_GROUP
  • QUEUE

Default: QUEUE

fifo_throughput_limit:

  • PER_QUEUE
  • PER_MESSAGE_GROUP_ID

Default: PER_QUEUE

An example of the options from boto3:
https://boto3.amazonaws.com/v1/documentation/api/latest/reference/services/sqs.html#SQS.Client.set_queue_attributes

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@westonsteimel westonsteimel added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 10, 2021
@github-actions github-actions bot added the @aws-cdk/aws-sqs Related to Amazon Simple Queue Service label Jun 10, 2021
@druska
Copy link

druska commented Jun 10, 2021

As far as I can tell, these properties aren't even available in CloudFormation yet.
https://docs.amazonaws.cn/en_us/AWSCloudFormation/latest/UserGuide/aws-properties-sqs-queues.html

@njlynch njlynch added effort/medium Medium work item – several days of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 11, 2021
@njlynch
Copy link
Contributor

njlynch commented Jun 11, 2021

Thanks for the feature request!

As @druska points out (thanks!), it looks like this feature isn't available via CloudFormation yet. Once support is added there, we can introduce the support to the Queue construct.

@njlynch njlynch removed their assignment Jun 11, 2021
@paul-doherty
Copy link
Contributor

paul-doherty pushed a commit to paul-doherty/aws-cdk that referenced this issue Jun 18, 2021
@njlynch njlynch removed the needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. label Jun 24, 2021
@mergify mergify bot closed this as completed in #15202 Jun 24, 2021
mergify bot pushed a commit that referenced this issue Jun 24, 2021
Closes #15063

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
Closes aws#15063

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-sqs Related to Amazon Simple Queue Service effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants