Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(pipelines): need full control of BuildSpec #15169

Closed
rix0rrr opened this issue Jun 17, 2021 · 7 comments · Fixed by #15625
Closed

(pipelines): need full control of BuildSpec #15169

rix0rrr opened this issue Jun 17, 2021 · 7 comments · Fixed by #15625
Assignees
@hoegertn
Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Milestone
[GA] CDK Pipelines

Comments

@rix0rrr
Copy link
Contributor

rix0rrr commented Jun 17, 2021

So set things like runtime-versions, caching, etc.

Would be good if we could merge artifacts parts of buildspecs...

This is a 🚀 Feature Request
@rix0rrr rix0rrr added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jun 17, 2021
@rix0rrr rix0rrr added this to the [GA] CDK Pipelines milestone Jun 17, 2021
@github-actions github-actions bot added the @aws-cdk/pipelines CDK Pipelines library label Jun 17, 2021
@hoegertn
Copy link
Contributor

For which CodeBuild job? Synth, Assets, or UpdatePipeline?

@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 17, 2021

Synth is foremost in my mind.

@mrpackethead
Copy link

+1 for this. This would be reallyk handy.

@hoegertn
Copy link
Contributor

@rix0rrr did you create this for tracking only or is this not on your roadmap? I could take it over if you like.

@rix0rrr rix0rrr added effort/medium Medium work item – several days of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Jun 21, 2021
@rix0rrr rix0rrr removed their assignment Jun 21, 2021
@rix0rrr
Copy link
Contributor Author

rix0rrr commented Jun 21, 2021

Notes on our discussion:

  • BuildSpecs will become mergeable
  • In principle this can be serviced by doing a deep JSON merge (recurse into objects, append lists), with the following exceptions:
    • Decided to disallow merging of artifact specs (actually impossible since we can't merge two buildspecs with a single primary output into a buildspec with multiple outputs--in case of multiple outputs they must have identifiers but we won't have that information)
    • In case of test reports we replace the whole object with the RHS (instead of recursively merging)
  • SynthAction and the Pipeline will get buildSpec? or partialBuildSpec? properties (name tbd) which will be merged with the generated buildspecs to produce a full, final buildspec.

@mrpackethead
Copy link

mrpackethead commented Jun 23, 2021 •
edited
Loading

Possibly related, and you might be able to address this with this work. ( or not )
#15279

Providing more control over the mutate stage.

@rix0rrr rix0rrr mentioned this issue Jun 28, 2021
Closed
@hoegertn hoegertn mentioned this issue Jun 28, 2021
Merged
mergify bot pushed a commit that referenced this issue Jul 1, 2021
@hoegertn
feat(codebuild): improve merging of BuildSpecs (#15332)
e68087d 
First steps for #15169 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@hoegertn hoegertn mentioned this issue Jul 2, 2021
Closed
2 tasks
@rix0rrr rix0rrr mentioned this issue Jul 5, 2021
Closed
This was referenced Jul 13, 2021
Closed
Merged
@mergify mergify bot closed this as completed in #15625 Jul 19, 2021
mergify bot pushed a commit that referenced this issue Jul 19, 2021
@hoegertn
fix(pipelines): CodeBuildStep.partialBuildSpec not used, buildspec …
d8dc818 
…control for legacy API (#15625)

this fixes #15169

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@hoegertn @TikiTDO
fix(pipelines): CodeBuildStep.partialBuildSpec not used, buildspec …
3cf2696 
…control for legacy API (aws#15625)

this fixes aws#15169

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@hoegertn @hollanddd
feat(codebuild): improve merging of BuildSpecs (aws#15332)
139c982 
First steps for aws#15169 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@hoegertn @hollanddd
fix(pipelines): CodeBuildStep.partialBuildSpec not used, buildspec …
440ef1c 
…control for legacy API (aws#15625)

this fixes aws#15169

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hoegertn hoegertn

Labels
@aws-cdk/pipelines CDK Pipelines library effort/medium Medium work item – several days of effort feature-request A feature should be added or improved. p1
Projects
None yet
Milestone
[GA] CDK Pipelines
3 participants
@rix0rrr @hoegertn @mrpackethead