-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(assets): Support fromTar for docker image assets #15419
Comments
Thanks for submitting a request and PR for this @pgarbe! Someone should be able to review the PR soon 😄 |
Thanks. Still working on some tests, but looking forward to some feedback. |
Allows to use an existing tarball for an container image. It loads the image from the tarball instead of building the image from a Dockerfile. Fixes #15419 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Allows to use an existing tarball for an container image. It loads the image from the tarball instead of building the image from a Dockerfile. Fixes aws#15419 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Allows to use an existing tarball for an container image. It loads the image from the tarball instead of building the image from a Dockerfile. Fixes aws#15419 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
It should be possible to add Docker images also from an existing tar file.
Use Case
Some projects do not have a Dockerfile but use external tools to generate their images (e.g. jib). In that case, the image has to be uploaded manually to ECR and it's cumbersome to ensure that the stack has the correct reference (name / tag) But if it's handled as a regular container image asset CDK could do the heavy lifting.
Proposed Solution
Just an idea, needs to be validated:
Run
docker load -i myTar.tar | sed "s/Loaded image: //g"
as executable. This command returns the image name as required. Not sure yet, how to get the tar as asset from the synth to upload assets stage and how to deal with the hash (it should take over the hash of the tar file).Other
This is a 🚀 Feature Request
The text was updated successfully, but these errors were encountered: