Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-codepipeline): ActionDeclaration - Support CombineArtifacts configuration when BatchEnabled is enable #15455

Closed
2 tasks
martinmicunda opened this issue Jul 7, 2021 · 3 comments · Fixed by #15457
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2

Comments

@martinmicunda
Copy link
Contributor

martinmicunda commented Jul 7, 2021

See this doc which says

To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true. To combine the build artifacts into the same location, set the CombineArtifacts parameter of the configuration object to true.

The configuration object it is referring to is this.

It is not possible right now to provide this on the CodeBuildAction

Use Case

We need to add a combine artifacts for batch code build action to our pipeline.

Proposed Solution

    const codebuildAction = new codepipelineActions.CodeBuildAction({
      actionName: 'Build',
      project: createCodeBuildProject(),
      input,
      outputs,
      batchEnabled: true,
      combineBatchBuildArtifacts: true // something like this
    })

would set the CombineArtifacts and property on Configuration to true. The implementation should happen somewhere around this place.

Other

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request

@martinmicunda martinmicunda added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 7, 2021
@github-actions github-actions bot added the @aws-cdk/aws-codepipeline Related to AWS CodePipeline label Jul 7, 2021
@skinny85
Copy link
Contributor

skinny85 commented Jul 7, 2021

Thanks for opening the issue @martinmicunda. Pull Requests are always very much welcome 😉.

@skinny85 skinny85 removed their assignment Jul 7, 2021
@skinny85 skinny85 added effort/small Small work item – less than a day of effort good first issue Related to contributions. See CONTRIBUTING.md p2 and removed needs-triage This issue or PR still needs to be triaged. labels Jul 7, 2021
@skinny85 skinny85 removed their assignment Jul 8, 2021
@martinmicunda
Copy link
Contributor Author

@skinny85 PR created

@mergify mergify bot closed this as completed in #15457 Jul 9, 2021
mergify bot pushed a commit that referenced this issue Jul 9, 2021
…n CodeBuildAction (#15457)

See this [doc](https://docs.aws.amazon.com/codebuild/latest/userguide/sample-pipeline-batch.html) which says

> To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true. To combine the build artifacts into the same location, set the CombineArtifacts parameter of the configuration object to true.

The configuration object it is referring to is [this](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stages-actions.html#cfn-codepipeline-pipeline-stages-actions-configuration).

Closes #15455
@github-actions
Copy link

github-actions bot commented Jul 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
…n CodeBuildAction (aws#15457)

See this [doc](https://docs.aws.amazon.com/codebuild/latest/userguide/sample-pipeline-batch.html) which says

> To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true. To combine the build artifacts into the same location, set the CombineArtifacts parameter of the configuration object to true.

The configuration object it is referring to is [this](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stages-actions.html#cfn-codepipeline-pipeline-stages-actions-configuration).

Closes aws#15455
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
…n CodeBuildAction (aws#15457)

See this [doc](https://docs.aws.amazon.com/codebuild/latest/userguide/sample-pipeline-batch.html) which says

> To enable batch builds in CodePipeline, set the BatchEnabled parameter of the configuration object to true. To combine the build artifacts into the same location, set the CombineArtifacts parameter of the configuration object to true.

The configuration object it is referring to is [this](https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-codepipeline-pipeline-stages-actions.html#cfn-codepipeline-pipeline-stages-actions-configuration).

Closes aws#15455
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-codepipeline Related to AWS CodePipeline effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. good first issue Related to contributions. See CONTRIBUTING.md p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants