Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-kinesisfirehose): support for metrics in DeliveryStream #15543

Closed
2 tasks
madeline-k opened this issue Jul 14, 2021 · 1 comment · Fixed by #15545 or #15618
Closed
2 tasks

(aws-kinesisfirehose): support for metrics in DeliveryStream #15543

madeline-k opened this issue Jul 14, 2021 · 1 comment · Fixed by #15545 or #15618
Assignees
@otaviomacedo
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Milestone
[DevPreview] Kine...

Comments

@madeline-k
Copy link
Contributor

Use Case

Implement specific metrics functions: i.e. metricIncomingBytes()

Proposed Solution

See: https://github.com/aws/aws-cdk/pull/15505/files

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@madeline-k madeline-k added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 14, 2021
@github-actions github-actions bot added the @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose label Jul 14, 2021
This was referenced Jul 14, 2021
Closed
Merged
@madeline-k madeline-k linked a pull request Jul 14, 2021 that will close this issue
feat(aws-kinesisfirehose): specific metrics functions for DeliveryStream #15545
Merged
mergify bot pushed a commit that referenced this issue Jul 16, 2021
@madeline-k
feat(aws-kinesisfirehose): specific metrics functions for DeliveryStr…
b011392 
…eam (#15545)

Closes #15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@madeline-k madeline-k mentioned this issue Jul 17, 2021
Merged
@mergify mergify bot closed this as completed in #15618 Jul 28, 2021
mergify bot pushed a commit that referenced this issue Jul 28, 2021
@madeline-k
feat(kinesisfirehose): add metrics functions to IDeliveryStream (#15618)
33909ed 
Closes #15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@madeline-k @TikiTDO
feat(kinesisfirehose): add metrics functions to IDeliveryStream (aws#…
9761436 
…15618)

Closes aws#15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@madeline-k @hollanddd
feat(kinesisfirehose): add metrics functions to IDeliveryStream (aws#…
29eda3d 
…15618)

Closes aws#15543 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
[DevPreview] Kinesis Data Firehose
2 participants
@otaviomacedo @madeline-k