Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-kinesisfirehose): prefixes for delivery stream S3 destination #15551

Closed
2 tasks
madeline-k opened this issue Jul 14, 2021 · 1 comment · Fixed by #15552
Closed
2 tasks

(aws-kinesisfirehose): prefixes for delivery stream S3 destination #15551

madeline-k opened this issue Jul 14, 2021 · 1 comment · Fixed by #15552
Assignees
@otaviomacedo
Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Milestone
[DevPreview] Kine...

Comments

@madeline-k
Copy link
Contributor

Use Case

const s3Destination = new destinations.S3(bucket, {
  prefix: 'myFirehose/DeliveredYear=!{timestamp:yyyy}/anyMonth/rand=!{firehose:random-string}',
  errorOutputPrefix: 'myFirehoseFailures/!{firehose:error-output-type}/!{timestamp:yyyy}/anyMonth/!{timestamp:dd}',
});

https://docs.aws.amazon.com/firehose/latest/dev/s3-prefixes.html

Proposed Solution

See: https://github.com/aws/aws-cdk/pull/15505/files

  • 👋 I may be able to implement this feature request
  • ⚠️ This feature might incur a breaking change

This is a 🚀 Feature Request
@madeline-k madeline-k added feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 14, 2021
@github-actions github-actions bot added @aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose @aws-cdk/aws-s3 Related to Amazon S3 labels Jul 14, 2021
@madeline-k madeline-k mentioned this issue Jul 14, 2021
Merged
@BenChaimberg BenChaimberg removed the @aws-cdk/aws-s3 Related to Amazon S3 label Jul 23, 2021
@mergify mergify bot closed this as completed in #15552 Jul 28, 2021
mergify bot pushed a commit that referenced this issue Jul 28, 2021
@madeline-k
feat(kinesisfirehose-destinations): add support for prefixes in the S…
d227e48 
…3 destination (#15552)

Closes #15551 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
@madeline-k @TikiTDO
feat(kinesisfirehose-destinations): add support for prefixes in the S…
50b6bc9 
…3 destination (aws#15552)

Closes aws#15551 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
@madeline-k @hollanddd
feat(kinesisfirehose-destinations): add support for prefixes in the S…
ccdafa7 
…3 destination (aws#15552)

Closes aws#15551 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@otaviomacedo otaviomacedo

Labels
@aws-cdk/aws-kinesisfirehose Related to Amazon Kinesis Data Firehose feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
[DevPreview] Kinesis Data Firehose
Development

Successfully merging a pull request may close this issue.

feat(kinesisfirehose-destinations): add support for prefixes in the S3 destination aws/aws-cdk
3 participants
@otaviomacedo @BenChaimberg @madeline-k