Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(aws-lambda-event-sources): Max batch size for SQSEventSource is documented as 10, missing edge case. #15697

Closed
dominoanty opened this issue Jul 21, 2021 · 1 comment · Fixed by #15803
Assignees
Labels
@aws-cdk/aws-lambda-event-sources documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@dominoanty
Copy link

dominoanty commented Jul 21, 2021

Code documentation : https://github.com/aws/aws-cdk/blob/master/packages/@aws-cdk/aws-lambda-event-sources/lib/sqs.ts

    export interface SqsEventSourceProps {

    /**
     * The largest number of records that AWS Lambda will retrieve from your event
     * source at the time of invoking your function. Your function receives an
     * event with all the retrieved records.
     *
     * Valid Range: Minimum value of 1. Maximum value of 10.
     *
     * @default 10
     */
    readonly batchSize?: number;

But as per #11722 as well as the code, it seems that if the maxBatchingWindow is defined, batchSize can go upto 10,000. It would be good if this was documented in the interface itself.


This is a 📕 documentation issue

@dominoanty dominoanty added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Jul 21, 2021
@github-actions github-actions bot added the @aws-cdk/aws-batch Related to AWS Batch label Jul 21, 2021
@dominoanty dominoanty changed the title (SQSEventSourceProps): Max batch size for SQSEventSource is documented as 10, missing edge case. (aws-lambda-event-sources): Max batch size for SQSEventSource is documented as 10, missing edge case. Jul 21, 2021
@nija-at nija-at added effort/small Small work item – less than a day of effort p2 and removed @aws-cdk/aws-batch Related to AWS Batch needs-triage This issue or PR still needs to be triaged. labels Jul 28, 2021
@mergify mergify bot closed this as completed in #15803 Jul 28, 2021
mergify bot pushed a commit that referenced this issue Jul 28, 2021
…15803)

closes #15697


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Aug 3, 2021
…ws#15803)

closes aws#15697


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd pushed a commit to hollanddd/aws-cdk that referenced this issue Aug 26, 2021
…ws#15803)

closes aws#15697


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@aws-cdk/aws-lambda-event-sources documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants