-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(ec2): volumeName doesn't set name of volume #15831
Labels
Comments
peterwoodworth
added
bug
This issue is a bug.
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 30, 2021
github-actions
bot
added
the
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
label
Jul 30, 2021
peterwoodworth
added
effort/small
Small work item – less than a day of effort
p2
and removed
@aws-cdk/aws-ec2
Related to Amazon Elastic Compute Cloud
needs-triage
This issue or PR still needs to be triaged.
labels
Jul 30, 2021
mergify bot
pushed a commit
that referenced
this issue
Jul 30, 2021
fixes: #15831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
TikiTDO
pushed a commit
to TikiTDO/aws-cdk
that referenced
this issue
Aug 3, 2021
fixes: aws#15831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
hollanddd
pushed a commit
to hollanddd/aws-cdk
that referenced
this issue
Aug 26, 2021
fixes: aws#15831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24
pushed a commit
to david-doyle-as24/aws-cdk
that referenced
this issue
Sep 7, 2021
fixes: aws#15831 ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
When creating an L2 EC2 Volume, you can supposedly change the physical name of the resource with the property
volumeName
. In the code, the only place where the propvolumeName
is used is here inputted as thephysicalName
prop in super()physicalName
is never used anywhere. Here is where theCfnVolume
is created. Cloudformation volumes don't have a property that sets the physical name of the volume, so setting the name through a tag would be the way to set the physical name of a volume through the CDK.Currently the
volumeName
property does nothing on the L2 Volume construct. adding a tag to theCfnVolume
like so is my proposed solution to this problem:add a line below the creation of the
CfnVolume
calledresource
linked aboveThis is 🐛 Bug Report
The text was updated successfully, but these errors were encountered: