Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

L2.cfnresource: Make it easier to use escape hatches (CFN property overrides) #1595

Closed
eladb opened this issue Jan 22, 2019 · 0 comments
Closed

L2.cfnresource: Make it easier to use escape hatches (CFN property overrides) #1595

eladb opened this issue Jan 22, 2019 · 0 comments
Assignees
@eladb
Labels
@aws-cdk/core Related to core CDK functionality closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.

Comments

@eladb
Copy link
Contributor

eladb commented Jan 22, 2019

The current approach where users have to use "findChild" with a well-known construct ("Resource") is error prone and convoluted. We should make the underlying cloudformation resources available through the L2 API:

We shall call this property cfnresource to signal that it taps into the L1 layer:

const bucket = new s3.Bucket(...);
bucket.cfnresource.addPropertyOverride('Boom', 'Bam');

Should be enforced by an awslint rule.
@eladb eladb mentioned this issue Jan 22, 2019
Closed
@eladb eladb added @aws-cdk/core Related to core CDK functionality feature-request A feature should be added or improved. labels Jan 22, 2019
@eladb eladb changed the title Make it easier to use escape hatches (CFN property overrides) L2.cfnresource: Make it easier to use escape hatches (CFN property overrides) Mar 4, 2019
@eladb eladb mentioned this issue Mar 4, 2019
Closed
@aaronbrashears aaronbrashears mentioned this issue Apr 3, 2019
Closed
@lkoniecz lkoniecz mentioned this issue Jul 26, 2019
Closed
5 tasks
@NGL321 NGL321 added the closing-soon This issue will automatically close in 4 days unless further comments are made. label Sep 10, 2019
@NGL321 NGL321 added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Sep 10, 2019
@eladb eladb closed this as completed Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@eladb eladb

Labels
@aws-cdk/core Related to core CDK functionality closing-soon This issue will automatically close in 4 days unless further comments are made. feature-request A feature should be added or improved. pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eladb @NGL321