Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-ecr-assets): Un-closed parentheses in Overview README, typo #16171

Closed
douglasnaphas opened this issue Aug 23, 2021 · 2 comments · Fixed by #16172
Closed

(aws-ecr-assets): Un-closed parentheses in Overview README, typo #16171

douglasnaphas opened this issue Aug 23, 2021 · 2 comments · Fixed by #16172
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2

Comments

@douglasnaphas
Copy link
Contributor

https://docs.aws.amazon.com/cdk/api/latest/docs/aws-ecr-assets-readme.html
https://github.com/aws/aws-cdk/blame/v1.119.0/packages/%40aws-cdk/aws-ecr-assets/README.md#L49-L50

Change

Use asset.imageUri to reference the image (it includes both the ECR image URL and tag.

which has an un-closed parentheses, to

Use asset.imageUri to reference the image. It includes both the ECR image URL and tag.

This is a 📕 documentation issue
@douglasnaphas douglasnaphas added documentation This is a problem with documentation. feature-request A feature should be added or improved. needs-triage This issue or PR still needs to be triaged. labels Aug 23, 2021
@github-actions github-actions bot added @aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets labels Aug 23, 2021
@eladb
Copy link
Contributor

eladb commented Aug 23, 2021

Thanks! Contributions are welcome!

douglasnaphas added a commit to douglasnaphas/aws-cdk that referenced this issue Aug 23, 2021
@douglasnaphas
Correct un-closed parenthetical expression
b09c20b 
Closes aws#16171.

The expression is missing a right parentheses, and it is just as clear anyway as a new sentence.
@eladb eladb added p2 effort/small Small work item – less than a day of effort and removed needs-triage This issue or PR still needs to be triaged. labels Aug 23, 2021
@eladb eladb removed their assignment Aug 23, 2021
@douglasnaphas douglasnaphas mentioned this issue Aug 23, 2021
Merged
@mergify mergify bot closed this as completed in #16172 Sep 1, 2021
mergify bot pushed a commit that referenced this issue Sep 1, 2021
@douglasnaphas
docs(aws-ecr-assets): Correct un-closed parenthetical expression (#16172
349361d 
)

Closes #16171.

The expression is missing a right parentheses, and it is just as clear anyway as a new sentence.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Sep 1, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

madeline-k pushed a commit to madeline-k/aws-cdk that referenced this issue Sep 2, 2021
@douglasnaphas
docs(aws-ecr-assets): Correct un-closed parenthetical expression (aws…
e90d8d1 
…#16172)

Closes aws#16171.

The expression is missing a right parentheses, and it is just as clear anyway as a new sentence.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Sep 6, 2021
@douglasnaphas @TikiTDO
docs(aws-ecr-assets): Correct un-closed parenthetical expression (aws…
ba5e287 
…#16172)

Closes aws#16171.

The expression is missing a right parentheses, and it is just as clear anyway as a new sentence.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
david-doyle-as24 pushed a commit to david-doyle-as24/aws-cdk that referenced this issue Sep 7, 2021
@douglasnaphas @david-doyle-as24
docs(aws-ecr-assets): Correct un-closed parenthetical expression (aws…
92308e6 
…#16172)

Closes aws#16171.

The expression is missing a right parentheses, and it is just as clear anyway as a new sentence.


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/assets Related to the @aws-cdk/assets package @aws-cdk/aws-ecr-assets Related to AWS CDK Docker Image Assets documentation This is a problem with documentation. effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

docs(aws-ecr-assets): Correct un-closed parenthetical expression douglasnaphas/aws-cdk
2 participants
@eladb @douglasnaphas