Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): downgrade bootstrap stack error message needs a hint for new-style synthesis #16237

Merged
merged 4 commits into from
Oct 28, 2021
Merged

fix(cli): downgrade bootstrap stack error message needs a hint for new-style synthesis #16237

merged 4 commits into from
Oct 28, 2021

Conversation

AnuragMohapatra
Copy link
Contributor

Fix to the bootstrap error message on the version comparison to provide to peek at solution so as to warn users about new style stack synthesis not being enabled automatically in the cdk.json as the potential root cause

Fixes #16009


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Updating the bootstrap error message during version compare to provide a peek at the solution to be used for using the latest bootstrap version.
…during-bootstrap-failure

Updating the bootstrap upgrade error message
@gitpod-io
Copy link

gitpod-io bot commented Aug 26, 2021

Copy link
Contributor

@LukvonStrom LukvonStrom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couldn't you check for the explicit case, i.e. the parameter missing in the cdk.json directly? As the fix you're suggesting in this broader error message only applies to a narrow problem.

@peterwoodworth peterwoodworth changed the title fix: Update the bootstrap error message to warn user of potential root cause fix: Update the bootstrap error message to warn user of potential root cause Oct 21, 2021
@github-actions github-actions bot added the package/tools Related to AWS CDK Tools or CLI label Oct 21, 2021
@rix0rrr rix0rrr changed the title fix: Update the bootstrap error message to warn user of potential root cause fix(cli): downgrade bootstrap stack error message needs a hint for new-style synthesis Oct 27, 2021
@rix0rrr rix0rrr added the pr-linter/exempt-test The PR linter will not require test changes label Oct 27, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 27, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 53f246c
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit e55301b into aws:master Oct 28, 2021
@mergify
Copy link
Contributor

mergify bot commented Oct 28, 2021

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this pull request Feb 21, 2022
…w-style synthesis (aws#16237)

Fix to the bootstrap error message on the version comparison to provide to peek at solution so as to warn users about new style stack synthesis not being enabled automatically in the cdk.json as the potential root cause

Fixes aws#16009

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package/tools Related to AWS CDK Tools or CLI pr-linter/exempt-test The PR linter will not require test changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AWS CDK Toolkit: More informative error message for failed bootstrapping due to new style stack synthesis
4 participants