Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): downgrade bootstrap stack error message needs a hint for new-style synthesis #16237

Merged
merged 4 commits into from
Oct 28, 2021
Merged

fix(cli): downgrade bootstrap stack error message needs a hint for new-style synthesis #16237

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
35c3df9
Updating the bootstrap upgrade error message
AnuragMohapatra Aug 26, 2021
3cad2d5
Merge pull request #1 from AnuragMohapatra/feat/better-error-message-…
AnuragMohapatra Aug 26, 2021
be11812
Merge branch 'aws:master' into master
AnuragMohapatra Oct 20, 2021
53f246c
Merge branch 'master' into master
mergify[bot] Oct 27, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/aws-cdk/lib/api/bootstrap/deploy-bootstrap.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ export class BootstrapStack {

const newVersion = bootstrapVersionFromTemplate(template);
if (this.currentToolkitInfo.found && newVersion < this.currentToolkitInfo.version && !options.force) {
throw new Error(`Not downgrading existing bootstrap stack from version '${this.currentToolkitInfo.version}' to version '${newVersion}'. Use --force to force.`);
throw new Error(`Not downgrading existing bootstrap stack from version '${this.currentToolkitInfo.version}' to version '${newVersion}'. Use --force to force or set the '@aws-cdk/core:newStyleStackSynthesis' feature flag in cdk.json to use the latest bootstrap version.`);
}

const outdir = await fs.mkdtemp(path.join(os.tmpdir(), 'cdk-bootstrap'));
Expand Down Expand Up @@ -114,4 +114,4 @@ export function bootstrapVersionFromTemplate(template: any): number {
}
}
return 0;
}
}