-
Notifications
You must be signed in to change notification settings - Fork 4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
codepipeline: construct should allow 'disableInboundStageTransitions' to be set #1649
Comments
Still relevant. |
The current way to add this override is:
|
Do you have a more complete example? When I try to use that code snippet it can't find a child called Resource on the pipeline construct. const pipeline = new CdkPipeline(this, "SomePipeline", {...}) When running cdk synth I get a "No child with id: 'Resource'" error. |
@paulrichards-provar that's exactly how it works for me. I'm assuming you are on the latest CDK. Perhaps you can come up with a small example that gives that error? |
I'm using cdk version 1.109.0 (build c647e38) `import { Repository } from '@aws-cdk/aws-codecommit'; interface PipelineStackProps extends StackProps { export class PipelineStack extends Stack {
} |
Add a `disableTransition` options to disable transition to a stage. Closes aws#1649
Add a `transitionToEnabled` options to disable transition to a stage. A reason can be optionally specified with `transitionDisabledReason`. Closes #1649 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
|
Add a `transitionToEnabled` options to disable transition to a stage. A reason can be optionally specified with `transitionDisabledReason`. Closes aws#1649 ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [x] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)? * [x] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
The codepipeline construct doesn't allow the disableInboundStageTransitions property to be set. This is useful for pipelines you want to run on a schedule or some other event rather than for every source change.
There is a workaround via the CfnPipeline, but it would be great if we could do this through the construct, either in the Pipeline construct, the individual Stage constructs, or both.
Workaround code is:
The text was updated successfully, but these errors were encountered: