Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(aws-route53resolver): FirewallDomains.fromList() does not support wildcard subdomains #16527

Closed
zweger opened this issue Sep 17, 2021 · 2 comments · Fixed by #16538
Closed

(aws-route53resolver): FirewallDomains.fromList() does not support wildcard subdomains #16527

zweger opened this issue Sep 17, 2021 · 2 comments · Fixed by #16538
Labels
@aws-cdk/aws-route53resolver bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1

Comments

@zweger
Copy link

zweger commented Sep 17, 2021

Subdomains with a leading wildcard are rejected by CDK:
jsii.errors.JSIIError: Invalid domain: *.example.com. Valid characters: A-Z, a-z, 0-9, _, -, .

The Route 53 documentation indicates a leading wildcard is supported.

Reproduction Steps

This Python code errors during synthesis.

allow_list = aws_route53resolver.FirewallDomainList(
    self, 'AllowList',
    domains=aws_route53resolver.FirewallDomains.from_list(['*.example.com'])
)

What did you expect to happen?

I get a Firewall Domain List which includes a domain with a wildcard.

What actually happened?

jsii.errors.JSIIError: Invalid domain: *.example.com. Valid characters: A-Z, a-z, 0-9, _, -, .

Environment

  • CDK CLI Version : 1.122.0 (build ae09c16)
  • Framework Version:
  • Node.js Version: v12.16.2
  • OS : Amazon Linux 2
  • Language (Version): Python (3.7.10)

This is 🐛 Bug Report
@zweger zweger added bug This issue is a bug. needs-triage This issue or PR still needs to be triaged. labels Sep 17, 2021
jogold added a commit to jogold/aws-cdk that referenced this issue Sep 18, 2021
@jogold
fix(rout53resolver): FireWallDomainList throws with wildcard domains
0533f01 
Closes aws#16527
@jogold jogold mentioned this issue Sep 18, 2021
Merged
@njlynch njlynch added effort/small Small work item – less than a day of effort p1 and removed needs-triage This issue or PR still needs to be triaged. labels Sep 21, 2021
@njlynch njlynch removed their assignment Sep 21, 2021
@njlynch
Copy link
Contributor

njlynch commented Sep 21, 2021

Looks like @jogold is on it!

@njlynch njlynch added the in-progress This issue is being actively worked on. label Sep 21, 2021
@mergify mergify bot closed this as completed in #16538 Sep 21, 2021
mergify bot pushed a commit that referenced this issue Sep 21, 2021
@jogold
fix(route53resolver): FirewallDomainList throws with wildcard domains (…
643e5ee 
…#16538)

Closes #16527


----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
@aws-cdk/aws-route53resolver bug This issue is a bug. effort/small Small work item – less than a day of effort in-progress This issue is being actively worked on. p1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(route53resolver): FirewallDomainList throws with wildcard domains jogold/aws-cdk
4 participants
@skinny85 @njlynch @zweger @peterwoodworth