Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(appsync): add OpenSearch domain data source #16529

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

BenChaimberg
Copy link
Contributor

@BenChaimberg BenChaimberg commented Sep 17, 2021

Deprecate ElasticsearchDataSource and introduce OpenSearchDataSource as a replacement.

closes #16528


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@BenChaimberg BenChaimberg added pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. @aws-cdk/aws-appsync Related to AWS AppSync labels Sep 17, 2021
@gitpod-io
Copy link

gitpod-io bot commented Sep 17, 2021

@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Sep 17, 2021
@rix0rrr rix0rrr added feature-request A feature should be added or improved. p1 and removed pr/blocked This PR cannot be merged or reviewed, because it is blocked for some reason. @aws-cdk/aws-appsync Related to AWS AppSync contribution/core This is a PR that came from AWS. labels Mar 4, 2022
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Mar 4, 2022
@kaizencc kaizencc requested a review from a team March 11, 2022 20:18
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 922a9dc into master Mar 11, 2022
@mergify mergify bot deleted the chaimber/opensearch_rebrand_appsync branch March 11, 2022 22:29
@mergify
Copy link
Contributor

mergify bot commented Mar 11, 2022

Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildProject89A8053A-LhjRyN9kxr8o
  • Commit ID: 0aa53a6
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify bot pushed a commit that referenced this pull request Mar 15, 2022
#19296)

Closes #16530.

Depends on #16529. 

This PR deprecates all APIs in `elasticsearch` in favor of the `opensearchservice` module. However, it does not deprecate `elasticsearch` as a module, since there are rules in place that disallow stable modules (like `cloudformation-include`) from depending on deprecated modules. See #19392. 

> `ElasticsearchVersion` was not deprecated due to a quirk in how the module is imported. It looks like, on import, the static properties `public static readonly V7_10 = ElasticsearchVersion.of('7.10');` actually tries to make the api call `of()`, which is deprecated. So imports fail with a message about using the deprecated api `ElasticsearchVersion.of()`.
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
mergify bot pushed a commit that referenced this pull request Mar 16, 2022
----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution/core This is a PR that came from AWS. feature-request A feature should be added or improved. p1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(appsync): support OpenSearch data source
4 participants