Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(opensearch): remove patches #16531

Closed
BenChaimberg opened this issue Sep 17, 2021 · 1 comment · Fixed by #19886
Closed

(opensearch): remove patches #16531

BenChaimberg opened this issue Sep 17, 2021 · 1 comment · Fixed by #19886
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2

Comments

@BenChaimberg
Copy link
Contributor

The current implementation of the aws-opensearchservice module relies on patches to the CFN specification and the AWS JavaScript SDK.

The CFN specification can be removed when the public specification has been updated to include the new AWS::OpenSearchService::Domain resource (probably by 9/20). This information can be tracked in the @aws-cdk/cfnspec module.

The AWS JavaScript SDK can be removed when the Lambda Node.js runtime has been updated to use the AWS JavaScript SDK v2.985.0 or later (could be months; at the time of writing, the version is 3 months behind). This information can be tracked in the developer guide.

The following files/lines need to be removed:

This is a 🚀 Feature Request
@BenChaimberg BenChaimberg added p2 feature-request A feature should be added or improved. effort/small Small work item – less than a day of effort needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. labels Sep 17, 2021
@peterwoodworth peterwoodworth mentioned this issue Apr 12, 2022
Merged
4 tasks
@mergify mergify bot closed this as completed in #19886 Apr 13, 2022
mergify bot pushed a commit that referenced this issue Apr 13, 2022
@peterwoodworth
chore(opensearch): remove vestigial patches (#19886)
dd4d49f 
fixes #16531

verified that cfnspec includes `opensearchservice::domain` and that sdk version is > 2.985.0 (currently 2.1001.0)

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

StevePotter pushed a commit to StevePotter/aws-cdk that referenced this issue Apr 27, 2022
@peterwoodworth
chore(opensearch): remove vestigial patches (aws#19886)
b03d14e 
fixes aws#16531

verified that cfnspec includes `opensearchservice::domain` and that sdk version is > 2.985.0 (currently 2.1001.0)

----

### All Submissions:

* [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

### Adding new Unconventional Dependencies:

* [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md/#adding-new-unconventional-dependencies)

### New Features

* [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/master/INTEGRATION_TESTS.md)?
	* [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)?

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. needs-cfn This issue is waiting on changes to CloudFormation before it can be addressed. p2
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(opensearch): remove vestigial patches aws/aws-cdk
3 participants
@skinny85 @BenChaimberg @peterwoodworth