Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CDKv2GA]: Create "canaries" for CDKv2 #16593

Closed
njlynch opened this issue Sep 22, 2021 · 3 comments
Closed

[CDKv2GA]: Create "canaries" for CDKv2 #16593

njlynch opened this issue Sep 22, 2021 · 3 comments
Assignees
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. ops-excellence Operational Excellence p1
Milestone

Comments

@njlynch
Copy link
Contributor

njlynch commented Sep 22, 2021

Exactly like the CDKv1 infrastructure, CDKv2 needs to have a regularly scheduled job that downloads and installs the CDK, and uses it to deploy (and delete) a stack. The canary should be monitored and alarmed exactly as the existing v1 canary is today.

@njlynch njlynch added ops-excellence Operational Excellence p1 effort/medium Medium work item – several days of effort aws-cdk-lib Related to the aws-cdk-lib package labels Sep 22, 2021
@njlynch njlynch added this to the [GA] CDK V2 milestone Sep 22, 2021
@nija-at nija-at removed their assignment Sep 23, 2021
@madeline-k madeline-k self-assigned this Oct 11, 2021
@madeline-k
Copy link
Contributor

Paused this while I was on-call last week. Resuming today, should have a PR out in a day or so!

@madeline-k madeline-k added the in-progress This issue is being actively worked on. label Nov 1, 2021
mergify bot pushed a commit that referenced this issue Nov 3, 2021
…-cdk version (#17285)

If an environment variable, `$RELEASE_TAG` is defined, it will be appended to the end of the `npm install aws-cdk@` command. This will allow us to run canaries that test against v2 by specifying `RELEASE_TAG=next` in the environment variables. If `$RELEASE_TAG` is not defined, `npm install aws-cdk@latest` will be used. 

This PR also includes a comment in `release-notes.ts` that the v2 publishing verification canary is dependent on the format of the release notes. 
 
part of #16593, see https://github.com/cdklabs/cdk-ops/pull/1769 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

@madeline-k madeline-k reopened this Nov 9, 2021
@njlynch njlynch closed this as completed Nov 9, 2021
@github-actions
Copy link

github-actions bot commented Nov 9, 2021

⚠️COMMENT VISIBILITY WARNING⚠️

Comments on closed issues are hard for our team to see.
If you need more assistance, please either tag a team member or open a new issue that references this one.
If you wish to keep having a conversation with other community members under this issue feel free to do so.

TikiTDO pushed a commit to TikiTDO/aws-cdk that referenced this issue Feb 21, 2022
…-cdk version (aws#17285)

If an environment variable, `$RELEASE_TAG` is defined, it will be appended to the end of the `npm install aws-cdk@` command. This will allow us to run canaries that test against v2 by specifying `RELEASE_TAG=next` in the environment variables. If `$RELEASE_TAG` is not defined, `npm install aws-cdk@latest` will be used. 

This PR also includes a comment in `release-notes.ts` that the v2 publishing verification canary is dependent on the format of the release notes. 
 
part of aws#16593, see https://github.com/cdklabs/cdk-ops/pull/1769 

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
aws-cdk-lib Related to the aws-cdk-lib package effort/medium Medium work item – several days of effort in-progress This issue is being actively worked on. ops-excellence Operational Excellence p1
Projects
None yet
Development

No branches or pull requests

3 participants